Fix some corner cases

Author: termi-official

lib/NonlinearSolveFirstOrder/src/solve.jl

@@ -198,7 +198,7 @@ function SciMLBase.__init(
 
         has_linesearch = alg.linesearch !== missing && alg.linesearch !== nothing
         has_trustregion = alg.trustregion !== missing && alg.trustregion !== nothing
-        has_forcing = alg.forcing !== missing && alg.forcing !== nothing
+        has_forcing = alg.forcing !== missing && alg.forcing !== nothing && !(u isa Number) && !(J isa Diagonal)
 
         if has_trustregion && has_linesearch
             error("TrustRegion and LineSearch methods are algorithmically incompatible.")
@@ -274,7 +274,7 @@ function InternalAPI.step!(
         end
     end
 
-    has_forcing = cache.forcing_cache !== nothing && cache.forcing_cache !== missing
+    has_forcing = cache.forcing_cache !== nothing && cache.forcing_cache !== missing && !(cache.u isa Number) && !(J isa Diagonal)
 
     if has_forcing
         pre_step_forcing!(cache.forcing_cache, cache.descent_cache, J, cache.u, cache.fu, cache.nsteps)

lib/NonlinearSolveFirstOrder/test/rootfind_tests.jl

@@ -9,8 +9,6 @@ end
     using BenchmarkTools: @ballocated
     using StaticArrays: @SVector
 
-    u0s=([1.0, 1.0], @SVector[1.0, 1.0], 1.0)
-
     @testset for (concrete_jac, linsolve) in (
         (Val(false), KrylovJL_CG(; precs = nothing)),
         (Val(false), KrylovJL_GMRES(; precs = nothing)),
@@ -24,7 +22,7 @@ end
             ),
         ),
     )
-        @testset "[OOP] u0: $(typeof(u0))" for u0 in u0s
+        @testset "[OOP] u0: $(typeof(u0))" for u0 in ([1.0, 1.0], @SVector[1.0, 1.0])
             solver = NewtonRaphson(; forcing=EisenstatWalkerForcing2(), linsolve, concrete_jac)
             sol = solve_oop(quadratic_f, u0; solver)
             @test SciMLBase.successful_retcode(sol)