[core/api/certificate] Fix digest size type

Author: TofMassilia13320

api/stse_asymmetric_keys_management.c

@@ -179,7 +179,7 @@ stse_ReturnCode_t stse_sign_for_generic_public_key_slot(
     defined(STSE_CONF_USE_SYMMETRIC_KEY_PROVISIONING_WRAPPED_AUTHENTICATED)
 
     stse_ReturnCode_t ret;
-    PLAT_UI32 hash_length = stsafea_hash_info_table[hash_algo].length;
+    PLAT_UI16 hash_length = stsafea_hash_info_table[hash_algo].length;
     PLAT_UI8 hash_data[hash_length];
 
     if (pPrivate_key == NULL || pPayload == NULL || pSignature == NULL ||
@@ -188,9 +188,8 @@ stse_ReturnCode_t stse_sign_for_generic_public_key_slot(
     }
 
 #ifdef STSE_CONF_ECC_EDWARD_25519
-    if (private_key_type != STSE_ECC_KT_ED25519)
+    if (private_key_type != STSE_ECC_KT_ED25519) {
 #endif /* STSE_CONF_ECC_EDWARD_25519 */
-    {
         /* - Hash the payload */
         ret = stse_platform_hash_compute(
             hash_algo,
@@ -210,13 +209,10 @@ stse_ReturnCode_t stse_sign_for_generic_public_key_slot(
         pPrivate_key,
 #ifdef STSE_CONF_ECC_EDWARD_25519
         (private_key_type == STSE_ECC_KT_ED25519) ? pPayload : hash_data,
-#else
-            hash_length,
-#endif
-#ifdef STSE_CONF_ECC_EDWARD_25519
         (private_key_type == STSE_ECC_KT_ED25519) ? payload_length : hash_length,
 #else
-            hash_length,
+        hash_data,
+        hash_length,
 #endif
         pSignature);
 

certificate/stse_certificate_crypto.c

@@ -33,9 +33,9 @@ stse_ReturnCode_t stse_certificate_verify_cert_signature(const stse_certificate_
     }
 
 #ifdef STSE_CONF_STSAFE_L_SUPPORT
-    PLAT_UI32 digestSize = 32U;
+    PLAT_UI16 digestSize = 32U;
 #else
-    PLAT_UI32 digestSize = stsafea_hash_info_table[hash_algo].length;
+    PLAT_UI16 digestSize = stsafea_hash_info_table[hash_algo].length;
 #endif /* STSE_CONF_STSAFE_A_SUPPORT*/
     PLAT_UI8 digest[digestSize];
     PLAT_UI8 *digestPtr = digest;

certificate/stse_certificate_subparsing.c

@@ -203,7 +203,7 @@ void stse_certificate_parse_ECC_public_key(const PLAT_UI8 *EccPK, stse_certifica
                     next += size;
                     tag = stse_certificate_identify_ASN1_TLV(next, &parsed, &size, &next);
                     if (tag == TAG_BITSTRING) {
-                        if ((next[0] == 0x00U) && (stse_certificate->EllipticCurve !=  EC_Ed25519)) {
+                        if ((next[0] == 0x00U) && (stse_certificate->EllipticCurve != EC_Ed25519)) {
 
                             switch (next[1]) {
                             case 0x04U:

core/stse_platform.h

@@ -133,7 +133,7 @@ stse_ReturnCode_t stse_platform_ecc_verify(stse_ecc_key_type_t key_type,
  */
 stse_ReturnCode_t stse_platform_hash_compute(stse_hash_algorithm_t hash_algo,
                                              PLAT_UI8 *pPayload, PLAT_UI32 payload_length,
-                                             PLAT_UI8 *pHash, PLAT_UI32 *hash_length);
+                                             PLAT_UI8 *pHash, PLAT_UI16 *hash_length);
 
 #if defined(STSE_CONF_USE_HOST_KEY_ESTABLISHMENT) ||                      \
     defined(STSE_CONF_USE_HOST_KEY_PROVISIONING_WRAPPED) ||               \

services/stsafea/stsafea_host_key_slot.c

@@ -397,8 +397,8 @@ stse_ReturnCode_t stsafea_establish_host_key_authenticated(
 
     /* Hash algo ID */
     stse_frame_element_allocate(eHash_algo_id, STSAFEA_GENERIC_LENGTH_SIZE, NULL);
-    PLAT_UI8 padding_hash[STSAFEA_HASH_ALGO_ID_LENGTH_SIZE] = {0};
 #ifdef STSE_CONF_ECC_EDWARD_25519
+    PLAT_UI8 padding_hash[STSAFEA_HASH_ALGO_ID_LENGTH_SIZE] = {0};
     if (signature_public_key_type == STSE_ECC_KT_ED25519) {
         eHash_algo_id.length = STSAFEA_HASH_ALGO_ID_LENGTH_SIZE;
         eHash_algo_id.pData = padding_hash;