Skip to content

Commit ee0fb02

Browse files
shridhargadekarjakub-vavra-cz
authored andcommitted
realmd: Rearrange permit and deny method
Simplifying permit and deny method of realm to write testcases flexibly `realm permit` can allow/deny users, groups `realm deny` deny log in on entire realm
1 parent 9e4c3dd commit ee0fb02

File tree

1 file changed

+10
-14
lines changed

1 file changed

+10
-14
lines changed

sssd_test_framework/utils/realmd.py

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from __future__ import annotations
44

55
from pytest_mh import MultihostHost, MultihostUtility
6-
from pytest_mh.cli import CLIBuilder, CLIBuilderArgs
6+
from pytest_mh.cli import CLIBuilder
77
from pytest_mh.conn import ProcessResult
88

99
__all__ = [
@@ -191,37 +191,33 @@ def renew(
191191
command = ["realm", "renew", domain, "--verbose", *args]
192192
return self.host.conn.exec(command)
193193

194-
def permit(self, user: str, *, withdraw: bool = False, args: list[str] | None = None) -> ProcessResult:
194+
def permit(self, *, args: list[str] | None = None) -> ProcessResult:
195195
"""
196-
Permit users log in.
196+
Permit and deny users, groups local log in.
197197
198-
:param user: User to permit.
199-
:type user: str
200-
:param withdraw: Withdraw permission, defaults to False
201-
:type withdraw: bool, optional
202198
:param args: Additional arguments, defaults to None
203199
:type args: list[str] | None, optional
204200
:return: Result of called command.
205201
:rtype: ProcessResult
206202
"""
207-
cli_args: CLIBuilderArgs = {"withdraw": (self.cli.option.SWITCH, withdraw)}
208203
if args is None:
209204
args = []
210205

211-
return self.host.conn.exec(["realm", "permit", *self.cli.args(cli_args), *args, user])
206+
return self.host.conn.exec(["realm", "permit", *args])
212207

213-
def deny(self, user: str, *, args: list[str] | None = None) -> ProcessResult:
208+
def deny(self, *, args: list[str] | None = None) -> ProcessResult:
214209
"""
215-
Deny users log in.
210+
Deny local log in.
216211
217-
:param user: User.
218-
:type user: str
219212
:param args: Additional arguments, defaults to None
220213
:type args: list[str] | None, optional
221214
:return: Result of called command.
222215
:rtype: ProcessResult
223216
"""
224-
return self.permit(user, withdraw=True, args=args)
217+
if args is None:
218+
args = []
219+
220+
return self.host.conn.exec(["realm", "deny", *args])
225221

226222
def list(self, *, args: list[str] | None = None) -> ProcessResult:
227223
"""

0 commit comments

Comments
 (0)