Skip to content

Commit 73640fb

Browse files
committed
Removed local testing in favor of uploading images to dev instance
1 parent c69c4a7 commit 73640fb

File tree

2 files changed

+0
-42
lines changed

2 files changed

+0
-42
lines changed

README.md

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,3 @@ In order to build the Jupyter Docker Stack-based images locally, we need to spec
1616
```
1717
docker build . -f Dockerfile -t [your-dockerhub-username]/[image-name]:v[x.x] --target notebook-image
1818
```
19-
20-
#### Local Testing
21-
22-
In order to test these images locally, we need to include the second build stage `local-testing` which installs and runs coder in the container image.
23-
This includes a custom script for use as the container's entrypoint `run-coder.sh`.
24-
The manual configuration in the `local-testing` target is typically handled by Coder via template, so as to install the latest version at runtime as opposed to manually installing a version at build time.
25-
26-
*Note*: The `local-testing` targets should **NOT** be used with Coder due to the increased container image size and potentially conflicting installations of coder.
27-
28-
Due to the location of `run-coder.sh`, Jupyter images should be built from the root of the repository, for example:
29-
30-
```
31-
docker build . -f /image/jupyter/minimal/Dockerfile -t [your-dockerhub-username]/coder-minimal-notebook:v[x.x] --target local-testing
32-
```

images/jupyter/minimal/Dockerfile

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -39,31 +39,3 @@ USER coder
3939
WORKDIR /home/coder
4040
ENV HOME=/home/coder
4141
ENV NB_USER=coder
42-
43-
FROM notebook-image AS local-testing
44-
45-
USER root
46-
WORKDIR /root
47-
48-
# Fix permissions for coder home directory
49-
RUN chown -R coder:coder /home/coder
50-
51-
# Add directory for coder install for local testing in Docker; transer owner to coder user & group
52-
RUN mkdir -p /opt/code-server \
53-
&& chown -R coder:coder /opt/code-server
54-
55-
USER coder
56-
WORKDIR /home/coder
57-
58-
# Install coder/code-server for local testing in Docker -- coder will install its own version at runtime
59-
RUN curl -fsSL https://code-server.dev/install.sh | sh -s -- --method=standalone --prefix=/opt/code-server
60-
61-
# Override entrypoint and healthcheck from Jupyter base image for local testing in Docker
62-
COPY run-coder.sh /opt/run-coder.sh
63-
ENTRYPOINT [ "sh", "/opt/run-coder.sh" ]
64-
HEALTHCHECK --interval=30s --timeout=5s --start-period=60s --retries=5 \
65-
CMD curl -fsS http://0.0.0.0:13337/healthz || exit 1
66-
67-
# Expose coder port for local testing in Docker
68-
EXPOSE 13337
69-

0 commit comments

Comments
 (0)