use additional callback param

Author: sampaiodiego

apps/meteor/ee/server/hooks/federation/index.ts

@@ -252,18 +252,16 @@ callbacks.add(
 	'federation-matrix-before-create-direct-room',
 );
 
-callbacks.add('federation.beforeCreateDirectMessage', async (roomUsers) => {
+callbacks.add('federation.beforeCreateDirectMessage', async (roomUsers, extraData) => {
 	// TODO: use a shared helper to check whether a user is federated
 	// since the DM creation API doesn't tell us if the room is federated (unlike normal channels),
 	// we're currently inferring it: if any participant has a Matrix-style ID (@user:server), we treat the DM as federated
 	const hasFederatedMembers = roomUsers.some((user: unknown) => typeof user === 'string' && user.includes(':') && user.includes('@'));
 
 	if (hasFederatedMembers) {
-		return {
-			federated: true,
-			federation: {
-				version: 1,
-			},
+		extraData.federated = true;
+		extraData.federation = {
+			version: 1,
 		};
 	}
 });

apps/meteor/lib/callbacks.ts

@@ -78,7 +78,7 @@ interface EventLikeCallbackSignatures {
 		},
 	) => void;
 	'beforeCreateDirectRoom': (members: string[], room: IRoom) => void;
-	'federation.beforeCreateDirectMessage': (members: IUser[]) => void;
+	'federation.beforeCreateDirectMessage': (members: IUser[], extraData: Record<string, unknown>) => void;
 	'afterSetReaction': (message: IMessage, params: { user: IUser; reaction: string; shouldReact: boolean; room: IRoom }) => void;
 	'afterUnsetReaction': (
 		message: IMessage,

apps/meteor/server/methods/createDirectMessage.ts

@@ -74,10 +74,10 @@ export async function createDirectMessage(
 		options.subscriptionExtra = { open: true };
 	}
 
-	let extraData = {};
+	const extraData = {};
 
 	try {
-		extraData = await callbacks.run('federation.beforeCreateDirectMessage', roomUsers);
+		await callbacks.run('federation.beforeCreateDirectMessage', roomUsers, extraData);
 	} catch (error) {
 		throw new Meteor.Error((error as any)?.message);
 	}