fix room being created as IRoomNativeFederated

Author: sampaiodiego

apps/meteor/app/lib/server/functions/createRoom.ts

@@ -3,7 +3,6 @@ import { AppsEngineException } from '@rocket.chat/apps-engine/definition/excepti
 import { FederationMatrix, Message, Room, Team } from '@rocket.chat/core-services';
 import type { ICreateRoomParams, ISubscriptionExtraData } from '@rocket.chat/core-services';
 import type { ICreatedRoom, IUser, IRoom, RoomType } from '@rocket.chat/core-typings';
-import { isRoomNativeFederated } from '@rocket.chat/core-typings';
 import { Rooms, Subscriptions, Users } from '@rocket.chat/models';
 import { Meteor } from 'meteor/meteor';
 
@@ -183,8 +182,7 @@ export const createRoom = async <T extends RoomType>(
 		// options,
 	});
 
-	const shouldBeHandledByFederation = isRoomNativeFederated(extraData);
-	if (shouldBeHandledByFederation && owner && !(await hasPermissionAsync(owner._id, 'access-federation'))) {
+	if (hasFederatedMembers && owner && !(await hasPermissionAsync(owner._id, 'access-federation'))) {
 		throw new Meteor.Error('error-not-authorized-federation', 'Not authorized to access federation', {
 			method: 'createRoom',
 		});
@@ -297,13 +295,13 @@ export const createRoom = async <T extends RoomType>(
 	void notifyOnRoomChanged(room, 'inserted');
 
 	// If federated, we must create Matrix room BEFORE subscriptions so invites can be sent.
-	if (shouldBeHandledByFederation) {
+	if (hasFederatedMembers) {
 		// Reusing unused callback to create Matrix room.
 		// We should discuss the opportunity to rename it to something with "before" prefix.
 		await callbacks.run('federation.afterCreateFederatedRoom', room, { owner, originalMemberList: members, options });
 	}
 
-	await createUsersSubscriptions({ room, members, now, owner, options, shouldBeHandledByFederation });
+	await createUsersSubscriptions({ room, members, now, owner, options, shouldBeHandledByFederation: hasFederatedMembers });
 
 	if (type === 'c') {
 		if (room.teamId) {

apps/meteor/ee/server/hooks/federation/index.ts

@@ -1,12 +1,6 @@
 import { FederationMatrix, Authorization, MeteorError, Room } from '@rocket.chat/core-services';
-import {
-	isEditedMessage,
-	isRoomNativeFederated,
-	isUserNativeFederated,
-	type IMessage,
-	type IRoom,
-	type IUser,
-} from '@rocket.chat/core-typings';
+import { isEditedMessage, isRoomNativeFederated, isUserNativeFederated } from '@rocket.chat/core-typings';
+import type { IRoomNativeFederated, IMessage, IRoom, IUser } from '@rocket.chat/core-typings';
 import { validateFederatedUsername } from '@rocket.chat/federation-matrix';
 import { Rooms } from '@rocket.chat/models';
 
@@ -15,6 +9,7 @@ import { afterLeaveRoomCallback } from '../../../../lib/callbacks/afterLeaveRoom
 import { afterRemoveFromRoomCallback } from '../../../../lib/callbacks/afterRemoveFromRoomCallback';
 import { beforeAddUsersToRoom, beforeAddUserToRoom } from '../../../../lib/callbacks/beforeAddUserToRoom';
 import { beforeChangeRoomRole } from '../../../../lib/callbacks/beforeChangeRoomRole';
+import { prepareCreateRoomCallback } from '../../../../lib/callbacks/beforeCreateRoomCallback';
 import { FederationActions } from '../../../../server/services/room/hooks/BeforeFederationActions';
 
 // callbacks.add('federation-event-example', async () => FederationMatrix.handleExample(), callbacks.priority.MEDIUM, 'federation-event-example-handler');
@@ -282,3 +277,14 @@ callbacks.add(
 	callbacks.priority.HIGH,
 	'federation-matrix-after-create-direct-room',
 );
+
+prepareCreateRoomCallback.add(async ({ extraData }) => {
+	if (!extraData.federated) {
+		return;
+	}
+
+	// when we receive extraData.federated, we need to prepare the room to be considered IRoomNativeFederated.
+	// according to isRoomNativeFederated for a room to be considered IRoomNativeFederated it is enough to have
+	// only an empty "federation" object
+	(extraData as IRoomNativeFederated).federation = { version: 1 } as any;
+});

apps/meteor/lib/callbacks/beforeCreateRoomCallback.ts

@@ -6,4 +6,4 @@ export const beforeCreateRoomCallback =
 	Callbacks.create<(data: { owner: IUser; room: Omit<IRoom, '_id' | '_updatedAt'> }) => void>('beforeCreateRoom');
 
 export const prepareCreateRoomCallback =
-	Callbacks.create<(data: { type: IRoom['t']; extraData: { encrypted?: boolean } }) => void>('prepareCreateRoom');
+	Callbacks.create<(data: { type: IRoom['t']; extraData: Partial<IRoom> }) => void>('prepareCreateRoom');