Include what you use

Author: bjsowa

include/web_video_server/streamers/libav_streamer.hpp

@@ -42,7 +42,6 @@ extern "C"
 
 #include <chrono>
 #include <cstdint>
-#include <memory>
 #include <mutex>
 #include <string>
 
@@ -52,7 +51,6 @@ extern "C"
 #include "async_web_server_cpp/http_request.hpp"
 #include "rclcpp/node.hpp"
 
-#include "web_video_server/streamer.hpp"
 #include "web_video_server/streamers/image_transport_streamer.hpp"
 
 namespace web_video_server

src/streamer.cpp

@@ -30,6 +30,9 @@
 
 #include "web_video_server/streamer.hpp"
 
+#include <vector>
+#include <sstream>
+
 #include "rclcpp/node.hpp"
 
 #include "async_web_server_cpp/http_connection.hpp"

src/streamers/image_transport_streamer.cpp

@@ -34,6 +34,8 @@
 #include <exception>
 #include <functional>
 #include <mutex>
+#include <string>
+#include <vector>
 
 #include <boost/system/system_error.hpp>
 #include <opencv2/core.hpp>
@@ -141,7 +143,7 @@ void ImageTransportStreamerBase::initialize(const cv::Mat &)
 {
 }
 
-void ImageTransportStreamerBase::restream_frame(std::chrono::duration<double> max_age)
+void ImageTransportStreamerBase::restream_frame(std::chrono::duration<double>/* max_age */)
 {
   if (inactive_ || !initialized_) {
     return;
@@ -208,7 +210,7 @@ void ImageTransportStreamerBase::image_callback(const sensor_msgs::msg::Image::C
 
 void ImageTransportStreamerBase::try_send_image(
   const cv::Mat & img,
-  const std::chrono::steady_clock::time_point & time)
+  const std::chrono::steady_clock::time_point & /* time */)
 {
   try {
     std::scoped_lock lock(send_mutex_);

src/streamers/jpeg_streamers.cpp

@@ -36,7 +36,6 @@
 #include <cstring>
 #include <memory>
 #include <mutex>
-#include <sstream>
 #include <string>
 #include <vector>
 

src/streamers/libav_streamer.cpp

@@ -51,7 +51,6 @@ extern "C"
 #include <chrono>
 #include <cstddef>
 #include <cstdint>
-#include <memory>
 #include <mutex>
 #include <sstream>
 #include <stdexcept>
@@ -66,7 +65,6 @@ extern "C"
 #include "rclcpp/node.hpp"
 #include "rclcpp/logging.hpp"
 
-#include "web_video_server/streamer.hpp"
 #include "web_video_server/streamers/image_transport_streamer.hpp"
 
 // https://stackoverflow.com/questions/46884682/error-in-building-opencv-with-ffmpeg

src/streamers/png_streamers.cpp

@@ -35,7 +35,6 @@
 #include <cstring>
 #include <memory>
 #include <mutex>
-#include <sstream>
 #include <string>
 #include <vector>
 

src/streamers/ros_compressed_streamer.cpp

@@ -31,23 +31,27 @@
 #include "web_video_server/streamers/ros_compressed_streamer.hpp"
 
 #include <chrono>
+#include <cstdio>
 #include <exception>
 #include <functional>
 #include <memory>
 #include <mutex>
 #include <optional>
-#include <sstream>
 #include <string>
 #include <utility>
+#include <vector>
 
 #include <boost/asio/buffer.hpp>
 #include <boost/system/system_error.hpp>
 
 #include "async_web_server_cpp/http_connection.hpp"
 #include "async_web_server_cpp/http_reply.hpp"
 #include "async_web_server_cpp/http_request.hpp"
+#include "rclcpp/logger.hpp"
 #include "rclcpp/logging.hpp"
 #include "rclcpp/node.hpp"
+#include "rclcpp/qos.hpp"
+#include "rclcpp/subscription.hpp"
 #include "rmw/qos_profiles.h"
 #include "sensor_msgs/msg/compressed_image.hpp"
 
@@ -288,7 +292,7 @@ void RosCompressedSnapshotStreamer::send_image(
   }
 
   char stamp[20];
-  snprintf(
+  std::snprintf(
     stamp, sizeof(stamp), "%.06lf",
     std::chrono::duration_cast<std::chrono::duration<double>>(time.time_since_epoch()).count());
 

src/web_video_server.cpp

@@ -34,6 +34,7 @@
 #include <chrono>
 #include <cstring>
 #include <exception>
+#include <map>
 #include <memory>
 #include <mutex>
 #include <set>
@@ -42,7 +43,6 @@
 #include <vector>
 
 #include <boost/algorithm/string/join.hpp>
-#include <boost/algorithm/string/predicate.hpp>
 #include <boost/bind/bind.hpp>
 #include <boost/bind/placeholders.hpp>
 #include <boost/exception/exception.hpp>
@@ -51,6 +51,7 @@
 #include "async_web_server_cpp/http_request.hpp"
 #include "async_web_server_cpp/http_reply.hpp"
 #include "async_web_server_cpp/http_server.hpp"
+#include "pluginlib/exceptions.hpp"
 #include "rclcpp/node.hpp"
 #include "rclcpp/node_options.hpp"
 #include "rclcpp/logging.hpp"