Skip to content

Commit 1bb2067

Browse files
author
rick
committed
fix: pr comment related to test.
1 parent 2242cda commit 1bb2067

File tree

1 file changed

+21
-14
lines changed

1 file changed

+21
-14
lines changed

packages/roslib/test/service.test.ts

Lines changed: 21 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -204,23 +204,30 @@ describe("Service", () => {
204204
expect(server.isAdvertised).toBe(false);
205205
});
206206

207-
it("Successfully call /rosapi/get_time with an async return", async () => {
208-
const emptyRequest = {};
209-
210-
const getTimeService = new Service<
211-
typeof emptyRequest,
212-
{
213-
time: { sec: number; nanosec: number };
214-
}
207+
it("Successfully call a service with an asynchronous return", async () => {
208+
const server = new Service<
209+
undefined,
210+
{ success: boolean; message: string }
215211
>({
216212
ros,
217-
serviceType: "rosapi_msgs/srv/GetTime",
218-
name: "/rosapi/get_time",
213+
serviceType: "std_srvs/Trigger",
214+
name: "/test_service",
219215
});
216+
await server.advertise((_request, response) => {
217+
response.success = true;
218+
response.message = "bar";
219+
return true;
220+
});
221+
const client = new Service({
222+
ros,
223+
serviceType: "std_srvs/Trigger",
224+
name: "/test_service",
225+
});
226+
const response = await client.callServiceAsync({});
220227

221-
const response = await getTimeService.callServiceAsync(emptyRequest);
222-
223-
expect(response.time.sec).toBeDefined();
224-
expect(response.time.nanosec).toBeDefined();
228+
expect(response).toEqual({
229+
success: true,
230+
message: "bar",
231+
});
225232
});
226233
});

0 commit comments

Comments
 (0)