Merge pull request #254 from ReCodEx/robust-localization

Making API more robust when some part of the localized text is not pr…

Author: janbuchar

app/V1Module/presenters/AssignmentsPresenter.php

@@ -265,18 +265,18 @@ public function actionUpdateDetail(string $id) {
         throw new InvalidArgumentException("External assignment link is not a valid URL");
       }
 
-      $localized = new LocalizedExercise(
-        $lang, $localization["name"], $localization["text"],
+      $localizedTexts[$lang] = new LocalizedExercise(
+        $lang,
+        trim(Arrays::get($localization, "name", "")),
+        trim(Arrays::get($localization, "text", "")),
         $localizedExercise ? $localizedExercise->getDescription() : "",
         $externalAssignmentLink ?: null
       );
 
-      $localizedTexts[$lang] = $localized;
-
       if (array_key_exists("studentHint", $localization)) {
         $localizedAssignments[$lang] = new LocalizedAssignment(
           $lang,
-          $localization["studentHint"]
+          trim(Arrays::get($localization, "studentHint", ""))
         );
       }
     }

app/V1Module/presenters/ExercisesPresenter.php

@@ -285,7 +285,11 @@ public function actionUpdateDetail(string $id) {
       $localization["description"] = $localization["description"] ?? "";
 
       $localized = new LocalizedExercise(
-        $lang, $localization["name"], $localization["text"], $localization["description"], $externalAssignmentLink ?: null
+        $lang,
+        trim(Arrays::get($localization, "name", "")),
+        trim(Arrays::get($localization, "text", "")),
+        trim(Arrays::get($localization, "description", "")),
+        $externalAssignmentLink ?: null
       );
 
       $localizations[$lang] = $localized;

app/V1Module/presenters/ShadowAssignmentsPresenter.php

@@ -172,7 +172,9 @@ public function actionUpdateDetail(string $id) {
       }
 
       $localized = new LocalizedShadowAssignment(
-        $lang, $localization["name"], $localization["text"],
+        $lang,
+        trim(Arrays::get($localization, "name", "")),
+        trim(Arrays::get($localization, "text", "")),
         $externalAssignmentLink ?: null
       );