Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes RcppArmadillo with Armadillo 15.2-rc1, updating the version from 15.0.2-2 to 15.1.99-1. The update includes significant internal refactoring and new features.
Key changes:
- Addition of the
rande()function for exponential distribution random number generation - Introduction of
Mat_noaliasandSpMat_noaliaswrapper classes for optimized matrix operations - Enhanced constructor overloads for
Mat,Col, andRowclasses to improve performance - Updates to multiple operator implementations to utilize the new noalias optimization pattern
Reviewed Changes
Copilot reviewed 136 out of 136 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| inst/include/current/armadillo_bits/arma_version.hpp | Version updated to 15.2-RC1 |
| inst/include/current/armadillo_bits/fn_rande.hpp | New file implementing exponential distribution RNG |
| inst/include/current/armadillo_bits/arma_rng.hpp | Added rande template struct for exponential distribution |
| inst/include/current/armadillo_bits/Mat_bones.hpp | Added Mat_noalias class and new constructor overloads |
| inst/include/current/armadillo_bits/SpMat_bones.hpp | Added SpMat_noalias class definition |
| inst/include/current/armadillo_bits/unwrap.hpp | Updated quasi_unwrap<subview_row> and partial_unwrap<subview_row> for better memory handling |
| inst/include/current/op_/glue_ files | Added apply() overloads accepting Mat_noalias and SpMat_noalias parameters |
| inst/include/current/armadillo_bits/fn_*.hpp | Changed many arma_inline to inline for various functions |
| DESCRIPTION, configure.ac, ChangeLog, inst/NEWS.Rd | Version and metadata updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.