Skip to content

Commit 580b76f

Browse files
committed
Fix N+1, update test
1 parent b0b1fd7 commit 580b76f

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

app/controllers/api/lessons_controller.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ def user_remixes(lessons)
9292

9393
def user_remix(lesson)
9494
lesson.project&.remixes
95-
&.includes(school_project: :feedback)
95+
&.includes(:school_project)
9696
&.where(user_id: current_user.id)
9797
&.accessible_by(current_ability)
9898
&.order(created_at: :asc)

spec/features/lesson/listing_lessons_spec.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@
233233
student = create(:student, school:)
234234
authenticated_in_hydra_as(student)
235235
create(:class_student, school_class:, student_id: student.id)
236-
student_project = create(:project, school:, lesson:, parent: lesson.project, user_id: student.id)
236+
student_project = create(:project, school:, lesson:, parent: lesson.project, remixed_from_id: lesson.project.id, user_id: student.id)
237237

238238
get('/api/lessons', headers:)
239239
data = JSON.parse(response.body, symbolize_names: true)
@@ -273,7 +273,6 @@
273273
)
274274
school_project = student_project.school_project
275275

276-
# 1 unread feedback
277276
create(
278277
:feedback,
279278
school_project: school_project,
@@ -282,7 +281,6 @@
282281
read_at: nil
283282
)
284283

285-
# 1 read feedback
286284
create(
287285
:feedback,
288286
school_project: school_project,

0 commit comments

Comments
 (0)