Pro Micro Pins swapped

[psr]

I think the pin definitions for d16 and d14 for the Sparkfun Pro Micro board are swapped. It was lucky that I happened to probe the other one when my program didn't work!

I suppose that fixing this would be a breaking change for anyone who has previously worked around the issue, but I can also imagine that I may well be the first.

I'm enjoying playing with the AVR HAL, keep up the good work!

[AlternativleyCoolSlimbo]

According to the schematic (located here), they are not in order.

So, in essence, I'm asking if you've taken that into account, or if, on your board, they are actually flipped around and 16 comes at the end?

[psr]

Hmm, I'd found that schematic, but I'd missed the fact that the pin names are annotated down the right hand side. The silkscreen of the clone I have matches this image on the Sparkfun website.

As you see, the pin second from bottom right is labelled as 16. I think it is pin 11 of JP6 on the schematic. I'm sure there is a logic to the numbering of the pins, but I haven't deduced it yet.

As you can see here, PB2 is assigned to d14. https://github.com/Rahix/avr-hal/blob/6807aaf32ea99bc860393b8f0fdaf4384ca011bc/arduino-hal/src/port/promicro.rs#L55C12-L58C17