Add transform to apply orientation to guidance#1537
Closed
diazandr3s wants to merge 8 commits intomainfrom
Closed
Conversation
Signed-off-by: Andres <[email protected]>
Signed-off-by: Andres <[email protected]>
for more information, see https://pre-commit.ci
wyli
approved these changes
Aug 29, 2023
Collaborator
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks, looks good to me, please note that this only works in 3d.
Signed-off-by: Andres <[email protected]>
|
Hi @diazandr3s , @yiheng-wang-nv will update the DeepEdit bundle according to your change here, is it OK? And please help review later. Thanks in advance. |
Signed-off-by: Andres <[email protected]>
yiheng-wang-nv
approved these changes
Sep 6, 2023
This was referenced Sep 6, 2023
8 tasks
yiheng-wang-nv
added a commit
to Project-MONAI/model-zoo
that referenced
this pull request
Sep 8, 2023
Fixes #500 . ### Description This PR is used to fix the orientation issue of the spleen deepedit annotation bundle. This PR refers to Project-MONAI/MONAILabel#1537 ### Status **Ready** ### Please ensure all the checkboxes: <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Codeformat tests passed locally by running `./runtests.sh --codeformat`. - [ ] In-line docstrings updated. - [ ] Update `version` and `changelog` in `metadata.json` if changing an existing bundle. - [ ] Please ensure the naming rules in config files meet our requirements (please refer to: `CONTRIBUTING.md`). - [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy` are correct in `metadata.json`. - [ ] Descriptions should be consistent with the content, such as `eval_metrics` of the provided weights and TorchScript modules. - [ ] Files larger than 25MB are excluded and replaced by providing download links in `large_file.yml`. - [ ] Avoid using path that contains personal information within config files (such as use `/home/your_name/` for `"bundle_root"`). --------- Signed-off-by: Yiheng Wang <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Andres <[email protected]>
for more information, see https://pre-commit.ci
Collaborator
|
Do we need this..? |
SachidanandAlle
approved these changes
Nov 21, 2023
Collaborator
|
/build |
1 similar comment
Collaborator
|
/build |
|
On our side, we check and it seems that we need this! Thanks for fixing it. |
yiheng-wang-nv
added a commit
to yiheng-wang-nv/model-zoo
that referenced
this pull request
Jul 29, 2024
Fixes Project-MONAI#500 . ### Description This PR is used to fix the orientation issue of the spleen deepedit annotation bundle. This PR refers to Project-MONAI/MONAILabel#1537 ### Status **Ready** ### Please ensure all the checkboxes: <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Codeformat tests passed locally by running `./runtests.sh --codeformat`. - [ ] In-line docstrings updated. - [ ] Update `version` and `changelog` in `metadata.json` if changing an existing bundle. - [ ] Please ensure the naming rules in config files meet our requirements (please refer to: `CONTRIBUTING.md`). - [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy` are correct in `metadata.json`. - [ ] Descriptions should be consistent with the content, such as `eval_metrics` of the provided weights and TorchScript modules. - [ ] Files larger than 25MB are excluded and replaced by providing download links in `large_file.yml`. - [ ] Avoid using path that contains personal information within config files (such as use `/home/your_name/` for `"bundle_root"`). --------- Signed-off-by: Yiheng Wang <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Collaborator
|
Closing this due to no activity |
|
@diazandr3s @SachidanandAlle isn't plans to fix/merge this or anything to fix? BTW:
|
Contributor
|
Here is a video demonstrating the issue that @bastiao mentioned, using the DeepEdit model in the Radiology Sample App. When we place positive points to indicate the liver in the top-left area of the image, the model does not appear to apply the feedback correctly. Instead, it produces blue segmentations identifying the liver in the bottom-right area of the image, which is not correct. deepedit_orientation.mp4 |
This was referenced Aug 12, 2025
Collaborator
|
Duplicate PR.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andres [email protected]