🧹 Medium Priority: Remove dead code and eliminate #[allow(dead_code)]

[quantumshiro]

Problem

The codebase violates the zero dead code policy outlined in CLAUDE.md with multiple instances of #[allow(dead_code)] and unused code. This makes the codebase harder to maintain and understand.

Files with Dead Code Issues

Smart Contract Module

• File: src/smart_contract/wasm_engine.rs (Lines 27, 32)

  • Issue: Fields marked with #[allow(dead_code)]
  • Action: Either implement usage methods or remove unused fields

• File: src/smart_contract/privacy_engine.rs

  • Issue: Unused structs and methods with dead_code allowances
  • Action: Implement proper usage or remove

Crypto Module

• File: src/crypto/anonymous_eutxo.rs
  • Issue: Unused helper functions and structs
  • Action: Create tests that use these functions or remove them

Network Module

• File: src/network/p2p_enhanced.rs
  • Issue: Debug-related fields and methods not actively used
  • Action: Implement proper debugging interfaces or remove

Modular Architecture

• File: src/modular/transaction_processor.rs
  • Issue: Unused processor variants and helper methods
  • Action: Implement full transaction processing pipeline or remove

Zero Dead Code Policy Implementation

According to CLAUDE.md guidelines:

• ✅ All code must be actively used
• ❌ No #[allow(dead_code)] annotations
• ✅ Zero compiler warnings allowed
• ✅ All fields and methods must have purpose

Refactoring Strategy

For each dead code instance:

1. Analyze Usage: Determine if code serves a future purpose
2. Implement Usage: Create methods/tests that use the code
3. Or Remove: Delete truly unused code
4. Add Tests: Ensure all remaining code is tested

Definition of Done

• Zero #[allow(dead_code)] annotations in codebase
• All struct fields are actively used
• All methods have test coverage or clear usage
• cargo clippy --lib -- -D warnings passes without dead code warnings
• Code size reduced by removing truly unused code

Benefits

• 🧹 Cleaner, more maintainable codebase
• 📏 Reduced binary size
• 🔍 Easier code navigation and understanding
• ✅ Compliance with CLAUDE.md standards
• 🧪 Better test coverage requirements

Priority: 📊 Medium

Important for code quality but not blocking critical functionality.

Estimated Effort: 3-4 days