Vectorize readers and writers, cleanup

Signed-off-by: Arham Chopra <[email protected]>

Author: arhamchopra

cpp/cmake/modules/FindDepsArrowAdapter.cmake

@@ -3,3 +3,25 @@ cmake_minimum_required(VERSION 3.7.2)
 # ARROW
 find_package(Arrow REQUIRED)
 include_directories(${ARROW_INCLUDE_DIR})
+
+# Resolve Arrow link targets based on platform and vcpkg configuration.
+# Sets CSP_ARROW_LINK_LIBS for use in target_link_libraries().
+# On Windows with vcpkg, also applies the ws2_32.dll fix and defines ARROW_STATIC.
+if(WIN32)
+    if(CSP_USE_VCPKG)
+        set(CSP_ARROW_LINK_LIBS Arrow::arrow_static)
+        add_compile_definitions(ARROW_STATIC)
+    else()
+        # Until we manage to get the fix for ws2_32.dll in arrow-16 into conda, manually fix the error here
+        get_target_property(LINK_LIBS Arrow::arrow_shared INTERFACE_LINK_LIBRARIES)
+        string(REPLACE "ws2_32.dll" "ws2_32" FIXED_LINK_LIBS "${LINK_LIBS}")
+        set_target_properties(Arrow::arrow_shared PROPERTIES INTERFACE_LINK_LIBRARIES "${FIXED_LINK_LIBS}")
+        set(CSP_ARROW_LINK_LIBS arrow_shared)
+    endif()
+else()
+    if(CSP_USE_VCPKG)
+        set(CSP_ARROW_LINK_LIBS arrow_static)
+    else()
+        set(CSP_ARROW_LINK_LIBS arrow)
+    endif()
+endif()

cpp/cmake/modules/FindDepsParquetAdapter.cmake

@@ -1,13 +1,29 @@
 cmake_minimum_required(VERSION 3.7.2)
 
-# ARROW
-find_package(Arrow REQUIRED)
-include_directories(${ARROW_INCLUDE_DIR})
+# ARROW (reuse FindDepsArrowAdapter for find_package + link target resolution)
+find_package(DepsArrowAdapter REQUIRED)
 
 # PARQUET
 find_package(Parquet REQUIRED)
 include_directories(${PARQUET_INCLUDE_DIR})
 
+# Resolve Parquet link targets based on platform and vcpkg configuration.
+# Sets CSP_PARQUET_LINK_LIBS for use in target_link_libraries().
+if(WIN32)
+    if(CSP_USE_VCPKG)
+        set(CSP_PARQUET_LINK_LIBS Parquet::parquet_static)
+        add_compile_definitions(PARQUET_STATIC)
+    else()
+        set(CSP_PARQUET_LINK_LIBS parquet_shared)
+    endif()
+else()
+    if(CSP_USE_VCPKG)
+        set(CSP_PARQUET_LINK_LIBS parquet_static)
+    else()
+        set(CSP_PARQUET_LINK_LIBS parquet)
+    endif()
+endif()
+
 # Other deps
 find_package(Thrift REQUIRED)
 find_package(Brotli REQUIRED)