correct check null/undefined for minimum and maximum (#1087)

Author: c4phesua

packages/docusaurus-plugin-openapi-docs/src/markdown/schema.test.ts

@@ -124,6 +124,18 @@ describe("getQualifierMessage", () => {
     expect(actual).toBe(expected);
   });
 
+  it("should render 0 minimum and maximum", () => {
+    const expected = "**Possible values:** `>= 0` and `<= 40`";
+    const actual = getQualifierMessage({ minimum: 0, maximum: 40 });
+    expect(actual).toBe(expected);
+  });
+
+  it("should render minimum and 0 maximum", () => {
+    const expected = "**Possible values:** `>= -10` and `<= 0`";
+    const actual = getQualifierMessage({ minimum: -10, maximum: 0 });
+    expect(actual).toBe(expected);
+  });
+
   it("should render boolean exclusiveMinimum and maximum", () => {
     const expected = "**Possible values:** `> 1` and `<= 40`";
     const actual = getQualifierMessage({

packages/docusaurus-plugin-openapi-docs/src/markdown/schema.ts

@@ -116,8 +116,8 @@ export function getQualifierMessage(schema?: SchemaObject): string | undefined {
   }
 
   if (
-    schema.minimum ||
-    schema.maximum ||
+    schema.minimum != null ||
+    schema.maximum != null ||
     typeof schema.exclusiveMinimum === "number" ||
     typeof schema.exclusiveMaximum === "number"
   ) {
@@ -126,16 +126,16 @@ export function getQualifierMessage(schema?: SchemaObject): string | undefined {
     let maximum;
     if (typeof schema.exclusiveMinimum === "number") {
       minimum = `\`> ${schema.exclusiveMinimum}\``;
-    } else if (schema.minimum && !schema.exclusiveMinimum) {
+    } else if (schema.minimum != null && !schema.exclusiveMinimum) {
       minimum = `\`>= ${schema.minimum}\``;
-    } else if (schema.minimum && schema.exclusiveMinimum === true) {
+    } else if (schema.minimum != null && schema.exclusiveMinimum === true) {
       minimum = `\`> ${schema.minimum}\``;
     }
     if (typeof schema.exclusiveMaximum === "number") {
       maximum = `\`< ${schema.exclusiveMaximum}\``;
-    } else if (schema.maximum && !schema.exclusiveMaximum) {
+    } else if (schema.maximum != null && !schema.exclusiveMaximum) {
       maximum = `\`<= ${schema.maximum}\``;
-    } else if (schema.maximum && schema.exclusiveMaximum === true) {
+    } else if (schema.maximum != null && schema.exclusiveMaximum === true) {
       maximum = `\`< ${schema.maximum}\``;
     }
 

packages/docusaurus-theme-openapi-docs/src/markdown/schema.ts

@@ -112,8 +112,8 @@ export function getQualifierMessage(schema?: SchemaObject): string | undefined {
   }
 
   if (
-    schema.minimum ||
-    schema.maximum ||
+    schema.minimum != null ||
+    schema.maximum != null ||
     typeof schema.exclusiveMinimum === "number" ||
     typeof schema.exclusiveMaximum === "number"
   ) {
@@ -122,16 +122,16 @@ export function getQualifierMessage(schema?: SchemaObject): string | undefined {
     let maximum;
     if (typeof schema.exclusiveMinimum === "number") {
       minimum = `\`> ${schema.exclusiveMinimum}\``;
-    } else if (schema.minimum && !schema.exclusiveMinimum) {
+    } else if (schema.minimum != null && !schema.exclusiveMinimum) {
       minimum = `\`>= ${schema.minimum}\``;
-    } else if (schema.minimum && schema.exclusiveMinimum === true) {
+    } else if (schema.minimum != null && schema.exclusiveMinimum === true) {
       minimum = `\`> ${schema.minimum}\``;
     }
     if (typeof schema.exclusiveMaximum === "number") {
       maximum = `\`< ${schema.exclusiveMaximum}\``;
-    } else if (schema.maximum && !schema.exclusiveMaximum) {
+    } else if (schema.maximum != null && !schema.exclusiveMaximum) {
       maximum = `\`<= ${schema.maximum}\``;
-    } else if (schema.maximum && schema.exclusiveMaximum === true) {
+    } else if (schema.maximum != null && schema.exclusiveMaximum === true) {
       maximum = `\`< ${schema.maximum}\``;
     }