Skip to content

Commit ea7d005

Browse files
authored
Announce who updated a teams ready state (#26)
Signed-off-by: Pugzy <[email protected]>
1 parent 26a175b commit ea7d005

File tree

4 files changed

+26
-23
lines changed

4 files changed

+26
-23
lines changed

src/main/java/dev/pgm/events/ready/ReadyCommands.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public void readyCommand(CommandSender sender, MatchPlayer player) {
2323
return;
2424
}
2525

26-
manager.ready(player.getParty());
26+
manager.ready(player.getParty(), player);
2727
}
2828

2929
@Command(aliases = "unready", desc = "Mark your team as no longer being ready")
@@ -35,6 +35,6 @@ public void unreadyCommand(CommandSender sender, MatchPlayer player) {
3535
return;
3636
}
3737

38-
manager.unready(player.getParty());
38+
manager.unready(player.getParty(), player);
3939
}
4040
}

src/main/java/dev/pgm/events/ready/ReadyListener.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public void onLeave(PlayerLeaveMatchEvent event) {
5656

5757
// if match starting and team was ready unready them
5858
if (event.getMatch().getPhase() == MatchPhase.STARTING && manager.isReady(party)) {
59-
manager.unready(party);
59+
manager.unready(party, null);
6060
}
6161
}
6262

src/main/java/dev/pgm/events/ready/ReadyManager.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,17 @@
11
package dev.pgm.events.ready;
22

33
import dev.pgm.events.utils.Response;
4+
import javax.annotation.Nullable;
45
import tc.oc.pgm.api.match.Match;
56
import tc.oc.pgm.api.party.Party;
67
import tc.oc.pgm.api.player.MatchPlayer;
78
import tc.oc.pgm.events.CountdownStartEvent;
89

910
public interface ReadyManager {
1011

11-
void ready(Party party);
12+
void ready(Party party, @Nullable MatchPlayer player);
1213

13-
void unready(Party party);
14+
void unready(Party party, @Nullable MatchPlayer player);
1415

1516
boolean isReady(Party party);
1617

src/main/java/dev/pgm/events/ready/ReadyManagerImpl.java

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,18 @@
66
import dev.pgm.events.utils.Parties;
77
import dev.pgm.events.utils.Response;
88
import java.time.Duration;
9-
import org.bukkit.Bukkit;
10-
import org.bukkit.ChatColor;
9+
import javax.annotation.Nullable;
1110
import tc.oc.pgm.api.match.Match;
1211
import tc.oc.pgm.api.match.MatchPhase;
1312
import tc.oc.pgm.api.party.Party;
1413
import tc.oc.pgm.api.player.MatchPlayer;
1514
import tc.oc.pgm.events.CountdownStartEvent;
15+
import tc.oc.pgm.lib.net.kyori.adventure.text.TextComponent;
16+
import tc.oc.pgm.lib.net.kyori.adventure.text.format.NamedTextColor;
1617
import tc.oc.pgm.match.ObserverParty;
1718
import tc.oc.pgm.start.StartCountdown;
1819
import tc.oc.pgm.start.StartMatchModule;
20+
import tc.oc.pgm.util.named.NameStyle;
1921

2022
public class ReadyManagerImpl implements ReadyManager {
2123

@@ -36,16 +38,16 @@ public void createMatchStart(Match match, Duration duration) {
3638
}
3739

3840
@Override
39-
public void ready(Party party) {
41+
public void ready(Party party, @Nullable MatchPlayer player) {
4042
Match match = party.getMatch();
4143

42-
if (party.isNamePlural()) {
43-
Bukkit.broadcastMessage(
44-
party.getColor() + party.getNameLegacy() + ChatColor.RESET + " are now ready.");
45-
} else {
46-
Bukkit.broadcastMessage(
47-
party.getColor() + party.getNameLegacy() + ChatColor.RESET + " is now ready.");
48-
}
44+
TextComponent.Builder message =
45+
text()
46+
.append(party.getName())
47+
.append(text(" marked as ").append(text("ready", NamedTextColor.GREEN)));
48+
if (player != null) message.append(text(" by ").append(player.getName(NameStyle.COLOR)));
49+
50+
match.sendMessage(message);
4951

5052
parties.ready(party);
5153
if (allReady(match)) {
@@ -54,16 +56,16 @@ public void ready(Party party) {
5456
}
5557

5658
@Override
57-
public void unready(Party party) {
59+
public void unready(Party party, @Nullable MatchPlayer player) {
5860
Match match = party.getMatch();
5961

60-
if (party.isNamePlural()) {
61-
Bukkit.broadcastMessage(
62-
party.getColor() + party.getNameLegacy() + ChatColor.RESET + " are now unready.");
63-
} else {
64-
Bukkit.broadcastMessage(
65-
party.getColor() + party.getNameLegacy() + ChatColor.RESET + " is now unready.");
66-
}
62+
TextComponent.Builder message =
63+
text()
64+
.append(party.getName())
65+
.append(text(" marked as ").append(text("unready", NamedTextColor.RED)));
66+
if (player != null) message.append(text(" by ").append(player.getName(NameStyle.COLOR)));
67+
68+
match.sendMessage(message);
6769

6870
if (allReady(match) && system.unreadyShouldCancel()) {
6971
// check if unready should cancel

0 commit comments

Comments
 (0)