Changed OltActionRule null dbTransaction check (#104)

* Changed OltActionRule null dbTransaction check

closes #103

* add unit test for OltRuleMissingTransactionException

* fixed code smell

Author: chrisstraw

src/OLT.Core.Rules/RuleBuilders/OltActionRule.cs

@@ -16,18 +16,13 @@ public abstract class OltActionRule<T> : OltRule, IOltActionRule
         protected Dictionary<string, OltDependentRule> DependentRules = new Dictionary<string, OltDependentRule>();
 
 
-        protected virtual bool HasTransaction { get; set; }
         protected abstract Task RunRuleAsync();
 
         #region [ Execute ]
 
         public virtual Task<List<OltRuleCanRunException>> CanExecuteAsync()
         {
             var list = new List<OltRuleCanRunException>();
-            if (!HasTransaction)
-            {
-                list.Add(new OltRuleMissingTransactionException(this));
-            }
             return Task.FromResult(list);
         }
 
@@ -83,9 +78,12 @@ public virtual Task ExecuteAsync<TContext>(TContext context)
         /// <exception cref="OltRuleCanRunException"></exception>
         public virtual async Task ExecuteAsync(IDbContextTransaction dbTransaction)
         {
-            HasTransaction = dbTransaction != null;
 
             var errors = await CanExecuteAsync();
+            if (dbTransaction == null)
+            {
+                errors.Add(new OltRuleMissingTransactionException(this));
+            }
             if (errors.Any())
             {
                 throw new AggregateException(errors);

tests/OLT.Core.Rules.Tests/ExceptionTests.cs

@@ -13,12 +13,19 @@ public class ExceptionTests : BaseUnitTests
     {
 
         [Fact]
-        public void MissingTransactionExceptionTest()
+        public async Task MissingTransactionExceptionTest()
         {
             var rule1 = new Test1Rule();
             var ex = new OltRuleMissingTransactionException(rule1);
             var expectedMsg = $"{rule1.RuleName} requires {nameof(IDbContextTransaction)}";
-            Assert.Equal(expectedMsg, ex.Message);        }
+            Assert.Equal(expectedMsg, ex.Message);
+
+            Func<Task> func = () => rule1.ExecuteAsync(null);
+            (await func.Should().ThrowAsync<AggregateException>()).WithInnerException<OltRuleMissingTransactionException>();            
+        }
+
+       
+
 
         [Fact]
         public async Task MissingServiceExceptionTest()