Generic Filter Mod to add GetValue (#86)

* closes #85

* Unit Test for Generic Filter Changes

Author: chrisstraw

src/OLT.Searchers.GenericFilter/IOltGenericFilter.cs

@@ -4,11 +4,13 @@ public interface IOltGenericFilter
     {
         string Key { get; }
         bool HasValue(IOltGenericParameter parameters);
+        object GetValue(IOltGenericParameter parameters);
     }
 
     public interface IOltGenericFilter<TEntity> : IOltGenericFilter, IOltEntityQueryBuilder<TEntity>  
         where TEntity : class, IOltEntity
     {
 
     }
+
 }

src/OLT.Searchers.GenericFilter/OltGenericFilter.cs

@@ -18,19 +18,30 @@ public OltGenericFilter(IOltGenericParameterParser<TValueType> parser, IOltEntit
 
 
 
-        public bool HasValue(IOltGenericParameter parameters)
+        public virtual bool HasValue(IOltGenericParameter parameters)
         {
             var hasValue = Parser.Parse(parameters);
             QueryBuilder.Value = Parser.Value;
             return hasValue;
         }
 
-        public IQueryable<TEntity> BuildQueryable(IQueryable<TEntity> queryable)
+        public virtual object GetValue(IOltGenericParameter parameters)
+        {
+            var hasValue = Parser.Parse(parameters);
+            if (hasValue)
+            {
+                return Parser.Value;
+            }
+            return default(TValueType);
+        }
+
+        public virtual IQueryable<TEntity> BuildQueryable(IQueryable<TEntity> queryable)
         {
             if (!Parser.HasValue) return queryable;
             QueryBuilder.Value = Parser.Value;
             return QueryBuilder.BuildQueryable(queryable);
         }
+      
     }
 
 }

tests/OLT.Searchers.Tests/Assets/FakeEntity.cs

@@ -16,12 +16,38 @@ public class FakeEntity : IOltEntity
         public string LastName { get; set; }
 
         public int SelectValue { get; set; }
+        public int? NullableInt { get; set; }
 
         public DateTimeOffset SomeDate { get; set; }
 
         public DateTimeOffset? DeletedOn { get; set; }
         public string DeletedBy { get; set; }
 
+        public static FakeEntity FakerData()
+        {
+            return new FakeEntity
+            {
+                Id = Faker.RandomNumber.Next(1000, 900000),
+                UniqueId = Guid.NewGuid(),
+                FirstName = Faker.Name.First(),
+                LastName = Faker.Name.Last(),
+                SelectValue = Faker.RandomNumber.Next(1000, 900000),
+                NullableInt = Faker.RandomNumber.Next(1000, 900000),
+                SomeDate = DateTimeOffset.Now.AddHours(Faker.RandomNumber.Next(-150, 150))
+            };
+        }
+
+        public static List<FakeEntity> FakerList(int number)
+        {
+            var list = new List<FakeEntity>();
+            for (int i = 0; i < number; i++)
+            {
+                var item = FakerData();
+                list.Add(item);
+            }
+            return list;
+        }
+
         public static FakeEntity FakerData(List<int> selectValues, bool deleted = false)
         {
             var result = new FakeEntity
@@ -31,6 +57,7 @@ public static FakeEntity FakerData(List<int> selectValues, bool deleted = false)
                 FirstName = Faker.Name.First(),
                 LastName = Faker.Name.Last(),
                 SelectValue = selectValues.OrderBy(p => Guid.NewGuid()).FirstOrDefault(),
+                NullableInt = Faker.RandomNumber.Next(1000, 900000),
                 SomeDate = DateTimeOffset.Now.AddHours(Faker.RandomNumber.Next(-150, 150))
             };
 

tests/OLT.Searchers.Tests/GenericFilterTests.cs

@@ -0,0 +1,42 @@
+using OLT.Constants;
+using OLT.Core;
+using OLT.Searchers.Tests.Assets;
+using System;
+using System.Linq;
+using Xunit;
+
+namespace OLT.Searchers.Tests
+{
+    public class GenericFilterTests
+    {
+        [Theory]
+        [InlineData("Test", "Test", true)]
+        [InlineData("", null, false)]
+        [InlineData(" ", null, false)]
+        [InlineData(null, null, false)]
+        public void String(string value, string expected, bool parseable)
+        {
+            var entities = FakeEntity.FakerList(10).AsQueryable();
+            var random = Faker.RandomNumber.Next();
+            var key = $"key_{random}";
+            var label = $"label_{random}";
+            var template = new OltFilterTemplateString(key, label, false);
+            var expr = new OltEntityExpressionStringStartsWith<FakeEntity>(p => p.FirstName);
+            var genericParameter = TestHelper.BuildGenericParameter(key, value);
+            var filter = new OltGenericFilter<FakeEntity, string>(template, expr);
+            Assert.Equal(parseable, filter.HasValue(genericParameter));
+            Assert.Equal(expected, filter.GetValue(genericParameter));
+
+            if (parseable)
+            {
+                Assert.Empty(filter.BuildQueryable(entities).ToList());
+            }
+            else
+            {
+                Assert.NotEmpty(filter.BuildQueryable(entities).ToList());
+            }
+        }
+
+       
+    }
+}