Skip to content

Commit 1de8de0

Browse files
committed
fix(lib): a3959: make use of ReadOnly error
1 parent 5e8e8ac commit 1de8de0

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

lib/src/devices/soundcore/a3959/modules/sound_modes/setting_handler.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ use crate::{
55
api::settings::{self, Range, Setting, SettingId, Value},
66
devices::soundcore::{
77
a3959::structures::{A3959SoundModes, ManualNoiseCanceling},
8-
standard::settings_manager::{SettingHandler, SettingHandlerResult},
8+
standard::settings_manager::{SettingHandler, SettingHandlerError, SettingHandlerResult},
99
},
1010
};
1111

@@ -85,9 +85,7 @@ where
8585
SoundModeSetting::NoiseCancelingMode => {
8686
sound_modes.noise_canceling_mode = value.try_as_enum_variant()?
8787
}
88-
SoundModeSetting::AdaptiveNoiseCanceling => {
89-
tracing::error!("tried to set read only setting {setting_id}")
90-
}
88+
SoundModeSetting::AdaptiveNoiseCanceling => return Err(SettingHandlerError::ReadOnly),
9189
SoundModeSetting::ManualNoiseCanceling => {
9290
sound_modes.manual_noise_canceling =
9391
ManualNoiseCanceling::new(value.try_as_i32()? as u8)

0 commit comments

Comments
 (0)