refactor: update searchValue property description and improve setter logic

Author: noraeb

README.md

@@ -44,7 +44,7 @@ This element was meant to be used only for plugins in this organization. If it s
 | `filterable`   |         | `boolean`      | `false`    | Whether list items can be filtered on \`headline\` and \`supportingText\` | FilterListBase |
 | `searchhelper` |         | `string`       | `'search'` | Placeholder for search input field                                        | FilterListBase |
 | `searchRegex`  |         | `RegExp`       | `/.*/i`    |                                                                           | FilterListBase |
-| `searchValue`  |         | `string`       |            | Public getter/setter to get/set search input value                        | FilterListBase |
+| `searchValue`  |         | `string`       |            | Current search filter value. Updates search regex when changed.           | FilterListBase |
 
 <details><summary>Private API</summary>
 
@@ -110,7 +110,7 @@ This element was meant to be used only for plugins in this organization. If it s
 | `filterable`       |         | `boolean`      | `false`    | Whether list items can be filtered on \`headline\` and \`supportingText\` | FilterListBase |
 | `searchhelper`     |         | `string`       | `'search'` | Placeholder for search input field                                        | FilterListBase |
 | `searchRegex`      |         | `RegExp`       | `/.*/i`    |                                                                           | FilterListBase |
-| `searchValue`      |         | `string`       |            | Public getter/setter to get/set search input value                        | FilterListBase |
+| `searchValue`      |         | `string`       |            | Current search filter value. Updates search regex when changed.           | FilterListBase |
 
 <details><summary>Private API</summary>
 
@@ -171,7 +171,7 @@ This element was meant to be used only for plugins in this organization. If it s
 | `filterable`   |         | `boolean` | `false`    | Whether list items can be filtered on \`headline\` and \`supportingText\` |                |
 | `searchhelper` |         | `string`  | `'search'` | Placeholder for search input field                                        |                |
 | `searchRegex`  |         | `RegExp`  | `/.*/i`    |                                                                           |                |
-| `searchValue`  |         | `string`  |            | Public getter/setter to get/set search input value                        |                |
+| `searchValue`  |         | `string`  |            | Current search filter value. Updates search regex when changed.           |                |
 
 <details><summary>Private API</summary>
 

base-list.spec.ts

@@ -2,7 +2,6 @@
 
 import { expect, fixture, html } from '@open-wc/testing';
 import { customElement } from 'lit/decorators.js';
-import { spy } from 'sinon';
 
 import { TextField } from '@scopedelement/material-web/textfield/internal/text-field';
 
@@ -67,25 +66,6 @@ describe('FilterListBase', () => {
       expect(regex.test('pineapple')).to.be.true;
       expect(regex.test('banana')).to.be.false;
     });
-
-    it('setter ignores duplicate values', () => {
-      element.searchValue = 'test';
-      const requestUpdateSpy = spy(element, 'requestUpdate');
-      element.searchValue = 'test';
-      expect(requestUpdateSpy).to.not.have.been.called;
-      requestUpdateSpy.restore();
-    });
-
-    it('setter triggers requestUpdate for new values', () => {
-      element.searchValue = 'initial';
-      const requestUpdateSpy = spy(element, 'requestUpdate');
-      element.searchValue = 'changed';
-      expect(requestUpdateSpy).to.have.been.calledWith(
-        'searchValue',
-        'initial'
-      );
-      requestUpdateSpy.restore();
-    });
   });
 
   describe('search field rendering', () => {

base-list.ts

@@ -54,20 +54,17 @@ export class FilterListBase extends ScopedElementsMixin(LitElement) {
   @state()
   protected _searchValue = '';
 
-  /** Public getter/setter to get/set search input value */
-  get searchValue(): string {
-    return this._searchValue;
-  }
-
+  /** Current search filter value. Updates search regex when changed. */
+  @property({ type: String })
   set searchValue(value: string) {
     const oldVal = this._searchValue;
     if (oldVal === value) return;
     this._searchValue = value;
     this.searchRegex = searchRegex(value);
-    if (this.searchInput && this.searchInput.value !== value) {
-      this.searchInput.value = value;
-    }
-    this.requestUpdate('searchValue', oldVal);
+  }
+
+  get searchValue(): string {
+    return this._searchValue;
   }
 
   protected onFilter(): void {