Skip to content

Commit 829a289

Browse files
CursedFlamesCursedFlames
committed
Mostly finish implementing chunk rendering - still buggy and needs tests
1 parent 5c073ef commit 829a289

File tree

17 files changed

+336
-102
lines changed

17 files changed

+336
-102
lines changed

‎src/main/java/io/github/opencubicchunks/cubicchunks/client/multiplayer/CubicClientLevel.java‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package io.github.opencubicchunks.cubicchunks.client.multiplayer;
22

3-
public interface CubicClientLevel {
3+
import io.github.opencubicchunks.cc_core.api.CubePos;
44

5+
public interface CubicClientLevel {
6+
void cc_onCubeLoaded(CubePos cubePos);
57
}

‎src/main/java/io/github/opencubicchunks/cubicchunks/client/renderer/CubicLevelRenderer.java‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
package io.github.opencubicchunks.cubicchunks.client.renderer;
2+
3+
import io.github.opencubicchunks.cc_core.api.CubePos;
4+
5+
public interface CubicLevelRenderer {
6+
void cc_onCubeLoaded(CubePos cubePos);
7+
}

‎src/main/java/io/github/opencubicchunks/cubicchunks/client/renderer/cube/CubicRenderRegionCache.java‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
package io.github.opencubicchunks.cubicchunks.client.renderer.cube;
2+
3+
import javax.annotation.Nullable;
4+
5+
import net.minecraft.core.BlockPos;
6+
import net.minecraft.world.level.Level;
7+
8+
public interface CubicRenderRegionCache {
9+
@Nullable RenderCubeRegion cc_createRegion(Level level, BlockPos start, BlockPos end, int padding, boolean nullForEmpty);
10+
}

‎src/main/java/io/github/opencubicchunks/cubicchunks/mixin/access/client/SectionRenderDispatcherAccess.java‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
package io.github.opencubicchunks.cubicchunks.mixin.access.client;
2+
3+
import net.minecraft.client.multiplayer.ClientLevel;
4+
import net.minecraft.client.renderer.chunk.SectionRenderDispatcher;
5+
import org.spongepowered.asm.mixin.Mixin;
6+
import org.spongepowered.asm.mixin.gen.Accessor;
7+
8+
@Mixin(SectionRenderDispatcher.class)
9+
public interface SectionRenderDispatcherAccess {
10+
@Accessor("level") ClientLevel cc_getLevel();
11+
}

‎src/main/java/io/github/opencubicchunks/cubicchunks/mixin/access/client/ViewAreaAccess.java‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
package io.github.opencubicchunks.cubicchunks.mixin.access.client;
2+
3+
import net.minecraft.client.renderer.ViewArea;
4+
import net.minecraft.client.renderer.chunk.SectionRenderDispatcher;
5+
import net.minecraft.core.BlockPos;
6+
import org.spongepowered.asm.mixin.Mixin;
7+
import org.spongepowered.asm.mixin.gen.Invoker;
8+
9+
@Mixin(ViewArea.class)
10+
public interface ViewAreaAccess {
11+
@Invoker("getRenderSectionAt") SectionRenderDispatcher.RenderSection cc_invokeGetRenderSectionAt(BlockPos pos);
12+
}

‎src/main/java/io/github/opencubicchunks/cubicchunks/mixin/core/common/client/multiplayer/MixinClientChunkCache.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import io.github.opencubicchunks.cc_core.api.CubicConstants;
1616
import io.github.opencubicchunks.cubicchunks.CanBeCubic;
1717
import io.github.opencubicchunks.cubicchunks.client.multiplayer.ClientCubeCache;
18+
import io.github.opencubicchunks.cubicchunks.client.multiplayer.CubicClientLevel;
1819
import io.github.opencubicchunks.cubicchunks.mixin.core.common.world.level.chunk.MixinChunkSource;
1920
import io.github.opencubicchunks.cubicchunks.mixin.dasmsets.ChunkToCubeSet;
2021
import io.github.opencubicchunks.cubicchunks.world.level.cube.EmptyLevelCube;
@@ -138,7 +139,7 @@ public void cc_replaceBiomes(int x, int y, int z, FriendlyByteBuf buffer) {
138139
levelCube.replaceWithPacketData(buffer, tag, consumer);
139140
}
140141

141-
// ((CubicClientLevel) this.level).onCubeLoaded(cubePos); // TODO (P3) onCubeLoaded call
142+
((CubicClientLevel) this.level).cc_onCubeLoaded(cubePos);
142143
// TODO event hook
143144
// net.neoforged.neoforge.common.NeoForge.EVENT_BUS.post(new net.neoforged.neoforge.event.level.ChunkEvent.Load(levelCube, false));
144145
return levelCube;

‎src/main/java/io/github/opencubicchunks/cubicchunks/mixin/core/common/client/multiplayer/MixinClientLevel.java‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,20 @@
11
package io.github.opencubicchunks.cubicchunks.mixin.core.common.client.multiplayer;
22

3+
import io.github.opencubicchunks.cc_core.api.CubePos;
34
import io.github.opencubicchunks.cubicchunks.MarkableAsCubic;
45
import io.github.opencubicchunks.cubicchunks.client.multiplayer.CubicClientLevel;
6+
import io.github.opencubicchunks.cubicchunks.client.renderer.CubicLevelRenderer;
57
import io.github.opencubicchunks.cubicchunks.mixin.core.common.world.level.MixinLevel;
68
import net.minecraft.client.multiplayer.ClientLevel;
9+
import net.minecraft.client.renderer.LevelRenderer;
10+
import org.spongepowered.asm.mixin.Final;
711
import org.spongepowered.asm.mixin.Mixin;
12+
import org.spongepowered.asm.mixin.Shadow;
813

914
@Mixin(ClientLevel.class)
1015
public abstract class MixinClientLevel extends MixinLevel implements CubicClientLevel, MarkableAsCubic {
1116
protected boolean cc_isCubic;
17+
@Shadow @Final private LevelRenderer levelRenderer;
1218

1319
@Override
1420
public void cc_setCubic() { cc_isCubic = true;}
@@ -21,6 +27,13 @@ public abstract class MixinClientLevel extends MixinLevel implements CubicClient
2127
return true;
2228
}
2329

30+
// TODO should eventually be DASM once BlockTintCache and entity storage are actually done in CC
31+
public void cc_onCubeLoaded(CubePos cubePos) {
32+
// this.tintCaches.forEach((p_194154_, p_194155_) -> p_194155_.invalidateForChunk(chunkPos.x, chunkPos.z));
33+
// this.entityStorage.startTicking(chunkPos);
34+
((CubicLevelRenderer) this.levelRenderer).cc_onCubeLoaded(cubePos);
35+
}
36+
2437
// unload
2538
// TODO: Phase 2 - this interacts with the lighting engine and will need to change to support cubes
2639

‎src/main/java/io/github/opencubicchunks/cubicchunks/mixin/core/common/client/renderer/MixinLevelRenderer.java‎

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,15 @@
55
import com.llamalad7.mixinextras.injector.wrapoperation.Operation;
66
import com.llamalad7.mixinextras.injector.wrapoperation.WrapOperation;
77
import com.llamalad7.mixinextras.sugar.Local;
8+
import io.github.notstirred.dasm.api.annotations.Dasm;
9+
import io.github.notstirred.dasm.api.annotations.redirect.redirects.AddTransformToSets;
10+
import io.github.notstirred.dasm.api.annotations.selector.MethodSig;
11+
import io.github.notstirred.dasm.api.annotations.transform.TransformFromMethod;
12+
import io.github.opencubicchunks.cc_core.api.CubePos;
813
import io.github.opencubicchunks.cubicchunks.CanBeCubic;
14+
import io.github.opencubicchunks.cubicchunks.client.renderer.CubicLevelRenderer;
915
import io.github.opencubicchunks.cubicchunks.client.renderer.CubicViewArea;
16+
import io.github.opencubicchunks.cubicchunks.mixin.dasmsets.ChunkToCubeSet;
1017
import net.minecraft.client.Minecraft;
1118
import net.minecraft.client.multiplayer.ClientLevel;
1219
import net.minecraft.client.renderer.LevelRenderer;
@@ -17,8 +24,9 @@
1724
import org.spongepowered.asm.mixin.Shadow;
1825
import org.spongepowered.asm.mixin.injection.At;
1926

27+
@Dasm(ChunkToCubeSet.class)
2028
@Mixin(LevelRenderer.class)
21-
public abstract class MixinLevelRenderer {
29+
public abstract class MixinLevelRenderer implements CubicLevelRenderer {
2230
@Shadow @Nullable private ClientLevel level;
2331
@Shadow @Final private Minecraft minecraft;
2432

@@ -40,7 +48,6 @@ private void cc_onSetupRender_repositionCamera(ViewArea viewArea, double x, doub
4048
((CubicViewArea) viewArea).cc_repositionCamera(this.minecraft.player.getX(), this.minecraft.player.getY(), this.minecraft.player.getZ());
4149
}
4250

43-
// TODO onChunkLoaded
44-
45-
51+
@AddTransformToSets(ChunkToCubeSet.class) @TransformFromMethod(@MethodSig("onChunkLoaded(Lnet/minecraft/world/level/ChunkPos;)V"))
52+
public native void cc_onCubeLoaded(CubePos cubePos);
4653
}

‎src/main/java/io/github/opencubicchunks/cubicchunks/mixin/core/common/client/renderer/MixinSectionOcclusionGraph.java‎

Lines changed: 67 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,52 @@
11
package io.github.opencubicchunks.cubicchunks.mixin.core.common.client.renderer;
22

3+
import javax.annotation.Nullable;
4+
5+
import com.llamalad7.mixinextras.injector.wrapoperation.Operation;
6+
import com.llamalad7.mixinextras.injector.wrapoperation.WrapOperation;
37
import io.github.notstirred.dasm.api.annotations.Dasm;
48
import io.github.notstirred.dasm.api.annotations.redirect.redirects.AddMethodToSets;
59
import io.github.notstirred.dasm.api.annotations.redirect.redirects.AddTransformToSets;
610
import io.github.notstirred.dasm.api.annotations.selector.MethodSig;
711
import io.github.notstirred.dasm.api.annotations.selector.Ref;
812
import io.github.notstirred.dasm.api.annotations.transform.TransformFromMethod;
913
import io.github.opencubicchunks.cc_core.api.CubePos;
10-
import io.github.opencubicchunks.cc_core.world.level.CloPos;
14+
import io.github.opencubicchunks.cc_core.utils.Coords;
15+
import io.github.opencubicchunks.cubicchunks.CanBeCubic;
16+
import io.github.opencubicchunks.cubicchunks.mixin.access.client.ViewAreaAccess;
1117
import io.github.opencubicchunks.cubicchunks.mixin.access.common.SectionOcclusionGraph$GraphEventsAccess;
1218
import io.github.opencubicchunks.cubicchunks.mixin.dasmsets.ChunkToCubeSet;
19+
import io.github.opencubicchunks.cubicchunks.server.level.CloTrackingView;
1320
import net.minecraft.client.renderer.SectionOcclusionGraph;
21+
import net.minecraft.client.renderer.ViewArea;
22+
import net.minecraft.client.renderer.chunk.SectionRenderDispatcher;
23+
import net.minecraft.core.BlockPos;
24+
import net.minecraft.core.Direction;
1425
import org.spongepowered.asm.mixin.Mixin;
26+
import org.spongepowered.asm.mixin.Shadow;
27+
import org.spongepowered.asm.mixin.injection.At;
28+
import org.spongepowered.asm.mixin.injection.Inject;
29+
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
30+
import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
1531

1632
@Dasm(ChunkToCubeSet.class)
1733
@Mixin(SectionOcclusionGraph.class)
1834
public abstract class MixinSectionOcclusionGraph {
19-
// TODO onChunkLoaded
20-
// TODO addNeighbors
21-
// TODO initializeQueueForFullUpdate
22-
// TODO runUpdates ChunkPos.asLong
23-
// TODO isInViewDistance
24-
// TODO maybe getRelativeFrom? unsure
35+
private boolean cc_isCubic = false;
36+
@Shadow @Nullable private ViewArea viewArea;
37+
38+
@Shadow protected abstract boolean isInViewDistance(BlockPos pos, BlockPos origin);
39+
40+
@Inject(method = "waitAndReset", at = @At("RETURN"))
41+
private void cc_onWaitAndReset(@Nullable ViewArea viewArea, CallbackInfo ci) {
42+
cc_isCubic = viewArea != null && ((CanBeCubic) viewArea.getLevelHeightAccessor()).cc_isCubic();
43+
}
2544

2645
@AddTransformToSets(ChunkToCubeSet.class) @TransformFromMethod(@MethodSig("onChunkLoaded(Lnet/minecraft/world/level/ChunkPos;)V"))
27-
public native void cc_onCubeLoaded();
46+
public native void cc_onCubeLoaded(CubePos cubePos);
2847

2948
@AddMethodToSets(sets = ChunkToCubeSet.class, owner = @Ref(SectionOcclusionGraph.class), method = @MethodSig("addNeighbors(Lnet/minecraft/client/renderer/SectionOcclusionGraph$GraphEvents;Lnet/minecraft/world/level/ChunkPos;)V"))
30-
private void cc_addNeighbors(SectionOcclusionGraph.GraphEvents graphEvents, CloPos cubePos) {
49+
private void cc_addNeighbors(SectionOcclusionGraph.GraphEvents graphEvents, CubePos cubePos) {
3150
var access = ((SectionOcclusionGraph$GraphEventsAccess) (Object) graphEvents);
3251
access.cc_chunksWhichReceivedNeighbors().add(CubePos.asLong(cubePos.getX() - 1, cubePos.getY(), cubePos.getZ()));
3352
access.cc_chunksWhichReceivedNeighbors().add(CubePos.asLong(cubePos.getX(), cubePos.getY() - 1, cubePos.getZ()));
@@ -36,4 +55,43 @@ private void cc_addNeighbors(SectionOcclusionGraph.GraphEvents graphEvents, CloP
3655
access.cc_chunksWhichReceivedNeighbors().add(CubePos.asLong(cubePos.getX(), cubePos.getY() + 1, cubePos.getZ()));
3756
access.cc_chunksWhichReceivedNeighbors().add(CubePos.asLong(cubePos.getX(), cubePos.getY(), cubePos.getZ() + 1));
3857
}
58+
59+
@WrapOperation(method = "initializeQueueForFullUpdate", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/renderer/ViewArea;getRenderSectionAt(Lnet/minecraft/core/BlockPos;)Lnet/minecraft/client/renderer/chunk/SectionRenderDispatcher$RenderSection;"))
60+
private @Nullable SectionRenderDispatcher.RenderSection cc_onInitializeQueueForFullUpdate_getRenderSectionAt(ViewArea instance, BlockPos pos, Operation<SectionRenderDispatcher.RenderSection> original) {
61+
var result = original.call(instance, pos);
62+
if (result == null && cc_isCubic) {
63+
throw new IllegalStateException("getRenderSectionAt should never return null in a cubic world");
64+
}
65+
return result;
66+
}
67+
68+
@WrapOperation(method = "runUpdates", at = @At(value = "INVOKE", target = "Lnet/minecraft/world/level/ChunkPos;asLong(Lnet/minecraft/core/BlockPos;)J"))
69+
private long cc_onRunUpdates_chunkPosAsLong(BlockPos pos, Operation<Long> original) {
70+
if (!cc_isCubic) return original.call(pos);
71+
return CubePos.asLong(pos);
72+
}
73+
74+
@Inject(method = "isInViewDistance", at = @At("HEAD"), cancellable = true)
75+
private void cc_onIsInViewDistance(BlockPos pos, BlockPos origin, CallbackInfoReturnable<Boolean> cir) {
76+
if (!cc_isCubic) return;
77+
int posCubeX = Coords.blockToCube(pos.getX());
78+
int posCubeY = Coords.blockToCube(pos.getY());
79+
int posCubeZ = Coords.blockToCube(pos.getZ());
80+
int originCubeX = Coords.blockToCube(origin.getX());
81+
int originCubeY = Coords.blockToCube(origin.getY());
82+
int originCubeZ = Coords.blockToCube(origin.getZ());
83+
cir.setReturnValue(CloTrackingView.cc_isInViewDistance(posCubeX, posCubeY, posCubeZ, Coords.sectionToCubeRenderDistance(this.viewArea.getViewDistance()), originCubeX, originCubeY, originCubeZ));
84+
}
85+
86+
@Inject(method = "getRelativeFrom", at = @At("HEAD"), cancellable = true)
87+
private void cc_onGetRelativeFrom(BlockPos pos, SectionRenderDispatcher.RenderSection section, Direction direction, CallbackInfoReturnable<SectionRenderDispatcher.RenderSection> cir) {
88+
if (!cc_isCubic) return;
89+
// Same as vanilla logic but we don't manually check Y coordinates since that's handled by isInViewDistance now
90+
BlockPos relativeOrigin = section.getRelativeOrigin(direction);
91+
if (!this.isInViewDistance(pos, relativeOrigin)) {
92+
cir.setReturnValue(null);
93+
} else {
94+
cir.setReturnValue(((ViewAreaAccess) this.viewArea).cc_invokeGetRenderSectionAt(relativeOrigin));
95+
}
96+
}
3997
}

‎src/main/java/io/github/opencubicchunks/cubicchunks/mixin/core/common/client/renderer/chunk/MixinRenderRegionCache.java‎

Lines changed: 30 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
import javax.annotation.Nullable;
44

55
import io.github.opencubicchunks.cc_core.api.CubePos;
6+
import io.github.opencubicchunks.cc_core.api.CubicConstants;
7+
import io.github.opencubicchunks.cc_core.utils.Coords;
8+
import io.github.opencubicchunks.cubicchunks.client.renderer.cube.CubicRenderRegionCache;
69
import io.github.opencubicchunks.cubicchunks.client.renderer.cube.RenderCube;
710
import io.github.opencubicchunks.cubicchunks.client.renderer.cube.RenderCubeRegion;
811
import io.github.opencubicchunks.cubicchunks.client.renderer.cube.RenderRegionCacheCubeInfo;
@@ -11,53 +14,57 @@
1114
import it.unimi.dsi.fastutil.longs.Long2ObjectOpenHashMap;
1215
import net.minecraft.client.renderer.chunk.RenderRegionCache;
1316
import net.minecraft.core.BlockPos;
14-
import net.minecraft.core.SectionPos;
1517
import net.minecraft.world.level.Level;
1618
import org.spongepowered.asm.mixin.Mixin;
1719
import org.spongepowered.asm.mixin.Shadow;
1820

1921
@Mixin(RenderRegionCache.class)
20-
public class MixinRenderRegionCache {
22+
public class MixinRenderRegionCache implements CubicRenderRegionCache {
2123
@Shadow private final Long2ObjectMap<RenderRegionCacheCubeInfo> chunkInfoCache = new Long2ObjectOpenHashMap<>();
2224

2325
// TODO can we possibly do this with DASM + mixin? probably not?
24-
@Nullable public RenderCubeRegion cc_createRegion(Level level, BlockPos start, BlockPos end, int padding, boolean nullForEmpty) {
26+
@Override @Nullable public RenderCubeRegion cc_createRegion(Level level, BlockPos start, BlockPos end, int padding, boolean nullForEmpty) {
2527
var cubicLevel = ((CubicLevel) level);
26-
int startX = SectionPos.blockToSectionCoord(start.getX() - padding);
27-
int startY = SectionPos.blockToSectionCoord(start.getY() - padding);
28-
int startZ = SectionPos.blockToSectionCoord(start.getZ() - padding);
29-
int endX = SectionPos.blockToSectionCoord(end.getX() + padding);
30-
int endY = SectionPos.blockToSectionCoord(end.getY() + padding);
31-
int endZ = SectionPos.blockToSectionCoord(end.getZ() + padding);
32-
RenderRegionCacheCubeInfo[][][] arenderregioncache$chunkinfo = new RenderRegionCacheCubeInfo[endX - startX + 1][endY - startY + 1][endZ - startZ + 1];
28+
int cubeStartX = Coords.blockToCube(start.getX() - padding);
29+
int cubeStartY = Coords.blockToCube(start.getY() - padding);
30+
int cubeStartZ = Coords.blockToCube(start.getZ() - padding);
31+
int cubeEndX = Coords.blockToCube(end.getX() + padding);
32+
int cubeEndY = Coords.blockToCube(end.getY() + padding);
33+
int cubeEndZ = Coords.blockToCube(end.getZ() + padding);
34+
RenderRegionCacheCubeInfo[][][] arenderregioncache$chunkinfo = new RenderRegionCacheCubeInfo[cubeEndX - cubeStartX + 1][cubeEndY - cubeStartY + 1][cubeEndZ - cubeStartZ + 1];
3335

34-
for(int x = startX; x <= endX; ++x) {
35-
for(int y = startX; y <= endY; ++y) {
36-
for(int z = startZ; z <= endZ; ++z) {
37-
arenderregioncache$chunkinfo[x - startX][y - startY][z - startZ] = this.chunkInfoCache
36+
for(int cubeX = cubeStartX; cubeX <= cubeEndX; ++cubeX) {
37+
for(int cubeY = cubeStartY; cubeY <= cubeEndY; ++cubeY) {
38+
for(int cubeZ = cubeStartZ; cubeZ <= cubeEndZ; ++cubeZ) {
39+
arenderregioncache$chunkinfo[cubeX - cubeStartX][cubeY - cubeStartY][cubeZ - cubeStartZ] = this.chunkInfoCache
3840
.computeIfAbsent(
39-
CubePos.asLong(x, y, z),
41+
CubePos.asLong(cubeX, cubeY, cubeZ),
4042
cubePosLong -> new RenderRegionCacheCubeInfo(cubicLevel.cc_getCube(CubePos.extractX(cubePosLong), CubePos.extractY(cubePosLong), CubePos.extractZ(cubePosLong)))
4143
);
4244
}
4345
}
4446
}
4547

46-
if (nullForEmpty && cc_isAllEmpty(start, end, startX, startY, startZ, arenderregioncache$chunkinfo)) {
48+
if (nullForEmpty && cc_isAllEmpty(start, end, cubeStartX, cubeStartY, cubeStartZ, arenderregioncache$chunkinfo)) {
4749
return null;
4850
} else {
49-
RenderCube[][][] arenderchunk = new RenderCube[endX - startX + 1][endY - startY + 1][endZ - startZ + 1];
51+
RenderCube[][][] arenderchunk = new RenderCube[cubeEndX - cubeStartX + 1][cubeEndY - cubeStartY + 1][cubeEndZ - cubeStartZ + 1];
5052

51-
for(int x = startX; x <= endX; ++x) {
52-
for(int y = startY; y <= endY; ++y) {
53-
for(int z = startZ; z <= endZ; ++z) {
54-
arenderchunk[x - startX][y - startY][z - startZ] = arenderregioncache$chunkinfo[x - startX][y - startY][z - startZ].renderChunk();
53+
for(int x = cubeStartX; x <= cubeEndX; ++x) {
54+
for(int y = cubeStartY; y <= cubeEndY; ++y) {
55+
for(int z = cubeStartZ; z <= cubeEndZ; ++z) {
56+
arenderchunk[x - cubeStartX][y - cubeStartY][z - cubeStartZ] = arenderregioncache$chunkinfo[x - cubeStartX][y - cubeStartY][z - cubeStartZ].renderChunk();
5557
}
5658
}
5759
}
5860

59-
var modelDataManager = level.getModelDataManager().snapshotSectionRegion(startX, startY, startZ, endX, endY, endZ);
60-
return new RenderCubeRegion(level, startX, startY, startZ, arenderchunk, modelDataManager);
61+
var maxSection = CubicConstants.DIAMETER_IN_SECTIONS - 1;
62+
63+
var modelDataManager = level.getModelDataManager().snapshotSectionRegion(
64+
Coords.cubeToSection(cubeStartX, 0), Coords.cubeToSection(cubeStartY, 0), Coords.cubeToSection(cubeStartZ, 0),
65+
Coords.cubeToSection(cubeEndX, maxSection), Coords.cubeToSection(cubeEndY, maxSection), Coords.cubeToSection(cubeEndZ, maxSection)
66+
);
67+
return new RenderCubeRegion(level, cubeStartX, cubeStartY, cubeStartZ, arenderchunk, modelDataManager);
6168
}
6269
}
6370

0 commit comments

Comments
 (0)