pending advisor and seed data sabo id strings

Author: chpy04

src/backend/src/prisma/seed-data/reimbursement-requests.seed.ts

@@ -1314,7 +1314,7 @@ export const seedReimbursementRequests = async (
     organization,
     new Date('2024-07-15')
   );
-  await ReimbursementRequestService.setSaboNumber(rr30.reimbursementRequestId, 12345, users.richieRich, organization);
+  await ReimbursementRequestService.setSaboNumber(rr30.reimbursementRequestId, 'abc123', users.richieRich, organization);
   await ReimbursementRequestService.inputReimbursementRequestInSabo(
     rr30.reimbursementRequestId,
     users.richieRich,
@@ -1382,7 +1382,7 @@ export const seedReimbursementRequests = async (
     organization,
     new Date('2024-07-18')
   );
-  await ReimbursementRequestService.setSaboNumber(rr31.reimbursementRequestId, 12346, users.mrKrabs, organization);
+  await ReimbursementRequestService.setSaboNumber(rr31.reimbursementRequestId, 'sdfkj3', users.mrKrabs, organization);
   await ReimbursementRequestService.inputReimbursementRequestInSabo(
     rr31.reimbursementRequestId,
     users.mrKrabs,
@@ -1450,7 +1450,7 @@ export const seedReimbursementRequests = async (
     organization,
     new Date('2024-06-10')
   );
-  await ReimbursementRequestService.setSaboNumber(rr32.reimbursementRequestId, 12340, users.monopolyMan, organization);
+  await ReimbursementRequestService.setSaboNumber(rr32.reimbursementRequestId, '324jj', users.monopolyMan, organization);
   await ReimbursementRequestService.inputReimbursementRequestInSabo(
     rr32.reimbursementRequestId,
     users.monopolyMan,
@@ -1523,7 +1523,7 @@ export const seedReimbursementRequests = async (
     organization,
     new Date('2024-05-20')
   );
-  await ReimbursementRequestService.setSaboNumber(rr33.reimbursementRequestId, 12335, users.johnBoddy, organization);
+  await ReimbursementRequestService.setSaboNumber(rr33.reimbursementRequestId, 'kaljf23', users.johnBoddy, organization);
   await ReimbursementRequestService.inputReimbursementRequestInSabo(
     rr33.reimbursementRequestId,
     users.johnBoddy,
@@ -1596,7 +1596,7 @@ export const seedReimbursementRequests = async (
     organization,
     new Date('2024-05-08')
   );
-  await ReimbursementRequestService.setSaboNumber(rr34.reimbursementRequestId, 12330, users.richieRich, organization);
+  await ReimbursementRequestService.setSaboNumber(rr34.reimbursementRequestId, 'newklajfd', users.richieRich, organization);
   await ReimbursementRequestService.inputReimbursementRequestInSabo(
     rr34.reimbursementRequestId,
     users.richieRich,

src/backend/src/routes/reimbursement-requests.routes.ts

@@ -157,7 +157,7 @@ reimbursementRequestsRouter.get('/pending-advisor/list', ReimbursementRequestCon
 reimbursementRequestsRouter.post(
   '/pending-advisor/send',
   body('saboNumbers').isArray(),
-  intMinZero(body('saboNumbers.*')),
+  nonEmptyString(body('saboNumbers.*')),
   validateInputs,
   ReimbursementRequestController.sendPendingAdvisorList
 );

src/backend/src/services/reimbursement-requests.services.ts

@@ -612,7 +612,7 @@ export default class ReimbursementRequestService {
    * @param saboNumbers the sabo numbers of the reimbursement requests to send
    * @param organizationId the organization the user is currently in
    */
-  static async sendPendingAdvisorList(sender: User, saboNumbers: number[], organizationId: string) {
+  static async sendPendingAdvisorList(sender: User, saboNumbers: string[], organizationId: string) {
     const organization = await prisma.organization.findUnique({
       where: { organizationId },
       include: { advisor: true }

src/frontend/src/apis/finance.api.ts

@@ -374,7 +374,7 @@ export const setSaboNumber = async (requestId: string, saboNumber: string) => {
  * @param saboNumbers The sabo numbers of the reimbursement requests to request approval for
  * @returns the response from the backend
  */
-export const sendPendingAdvisorList = (saboNumbers: number[]) => {
+export const sendPendingAdvisorList = (saboNumbers: string[]) => {
   return axios.post(apiUrls.financeSendPendingAdvisorList(), {
     saboNumbers
   });

src/frontend/src/hooks/finance.hooks.ts

@@ -794,9 +794,9 @@ export const useGetPendingAdvisorList = () => {
  * @returns the mutation to send the pending advisor list
  */
 export const useSendPendingAdvisorList = () => {
-  return useMutation<{ message: string }, Error, number[]>(
+  return useMutation<{ message: string }, Error, string[]>(
     ['reimbursement-requests', 'send-pending-advisor'],
-    async (saboNumbers: number[]) => {
+    async (saboNumbers: string[]) => {
       const { data } = await sendPendingAdvisorList(saboNumbers);
       return data;
     }

src/frontend/src/pages/FinancePage/FinanceComponents/PendingAdvisorListModal.tsx

@@ -15,8 +15,8 @@ const CommaSeparatedNumbersInput = ({
   onChange,
   error
 }: {
-  value: number[];
-  onChange: (saboNumbers: number[]) => void;
+  value: string[];
+  onChange: (saboNumbers: string[]) => void;
   error: Merge<FieldError, (FieldError | undefined)[]> | undefined;
 }) => {
   const [inputValue, setInputValue] = useState<string>(value.join(', '));
@@ -25,11 +25,8 @@ const CommaSeparatedNumbersInput = ({
     const inputValue = e.target.value;
     setInputValue(inputValue);
 
-    // Split the input string by commas and parse each number
-    const saboNumbers = inputValue
-      .split(',')
-      .map((saboNumber) => parseInt(saboNumber.trim()))
-      .filter((num) => !isNaN(num)); // Filter out NaN values
+    // Split the input string by commas
+    const saboNumbers = inputValue.split(',');
 
     onChange(saboNumbers);
   };
@@ -49,12 +46,12 @@ const CommaSeparatedNumbersInput = ({
 };
 
 const schema = yup.object().shape({
-  saboNumbers: yup.array().of(yup.number().required('SABO Number is required')).required('SABO Numbers are required')
+  saboNumbers: yup.array().of(yup.string().required('SABO Number is required')).required('SABO Numbers are required')
 });
 
 interface PendingAdvisorModalProps {
   open: boolean;
-  saboNumbers: number[];
+  saboNumbers: string[];
   onHide: () => void;
 }
 const PendingAdvisorModal: React.FC<PendingAdvisorModalProps> = ({ open, saboNumbers, onHide }) => {
@@ -74,7 +71,7 @@ const PendingAdvisorModal: React.FC<PendingAdvisorModalProps> = ({ open, saboNum
 
   const toast = useToast();
 
-  const onSubmit = async (data: { saboNumbers: number[] }) => {
+  const onSubmit = async (data: { saboNumbers: string[] }) => {
     try {
       await sendPendingAdvisorList(data.saboNumbers);
     } catch (error: unknown) {