ejabberd: withBootstrap flag for mod_invite

Not ideal to pull in the npm toolchain just for getting some static
files (this is upstream’s call), but is less maintenance than trying to
track the versions ourselves. This also means now that if you don’t plan
to use the built-in mod_invites page, you can opt out of the toolchain +
dependency.

Author: toastal

pkgs/by-name/ej/ejabberd/package.nix

@@ -17,8 +17,11 @@
   gd,
   autoreconfHook,
   gawk,
+  applyPatches,
   fetchFromGitHub,
   fetchgit,
+  fetchNpmDeps,
+  fetchpatch2,
   beamPackages,
   nixosTests,
   withMysql ? false,
@@ -35,6 +38,9 @@
   withRedis ? false,
   withImagemagick ? false,
   imagemagick,
+  withBootstrap ? true, # used for the built-in mod_invites page
+  nodejs,
+  npmHooks,
 }:
 
 let
@@ -136,6 +142,7 @@ let
     "ezlib"
   ];
 
+  npmToolingUsed = withBootstrap;
 in
 stdenv.mkDerivation (finalAttrs: {
   pname = "ejabberd";
@@ -150,6 +157,10 @@ stdenv.mkDerivation (finalAttrs: {
         rebar3_hex
       ];
     })
+  ]
+  ++ lib.optionals npmToolingUsed [
+    nodejs
+    npmHooks.npmConfigHook
   ];
 
   buildInputs = [
@@ -165,13 +176,41 @@ stdenv.mkDerivation (finalAttrs: {
   ++ lib.optional withLua allBeamDeps.luerl
   ++ lib.optional withRedis allBeamDeps.eredis;
 
+  npmDeps =
+    if npmToolingUsed then
+      (fetchNpmDeps {
+        name = "${finalAttrs.pname}-${finalAttrs.version}-npm-deps";
+        src =
+          if builtins.isNull finalAttrs.patches || builtins.length finalAttrs.patches <= 0 then
+            finalAttrs.src
+          else
+            # A bit of a hack, but if the package*.json files are patched,
+            # fetchNpmDeps will be out of sync
+            applyPatches {
+              inherit (finalAttrs) src patches;
+              name = "${finalAttrs.pname}-patched";
+            };
+        hash = "sha256-MTyoc8ozrCi3W0CXmxyLpyU8v+vlUjcbLnv/1ev/Qqo=";
+      })
+    else
+      null;
+
   src = fetchFromGitHub {
     owner = "processone";
     repo = "ejabberd";
     tag = finalAttrs.version;
     hash = "sha256-M38niXEW++SPAvqQ2cqEd23+w7lBDO5EPgu/QRdYbXo=";
   };
 
+  patches = [
+    (fetchpatch2 {
+      # Makes Bootstrap optional, drops jQuery
+      # https://github.com/processone/ejabberd/pull/4558
+      url = "https://patch-diff.githubusercontent.com/raw/processone/ejabberd/pull/4558.patch";
+      hash = "sha256-ONMQS7VRty6VYKVYcczEx9c/svqmyiTtZU/LAUz/PMY=";
+    })
+  ];
+
   passthru.tests = {
     inherit (nixosTests) ejabberd;
   };
@@ -186,10 +225,13 @@ stdenv.mkDerivation (finalAttrs: {
     (lib.enableFeature withLua "lua")
     (lib.enableFeature withTools "tools")
     (lib.enableFeature withRedis "redis")
+    (lib.enableFeature withBootstrap "bootstrap")
   ]
   ++ lib.optional withSqlite "--with-sqlite3=${sqlite.dev}";
 
-  enableParallelBuilding = true;
+  # The derivation wants to execute 2 dl_invites_page_deps.sh in parallel
+  # causing unzip conflicts
+  enableParallelBuilding = false;
 
   postPatch = ''
     patchShebangs .
@@ -198,6 +240,10 @@ stdenv.mkDerivation (finalAttrs: {
     touch _build/default/lib/.built
   '';
 
+  preBuild = lib.optionalString npmToolingUsed /* sh */ ''
+    npm run postinstall
+  '';
+
   env.REBAR_IGNORE_DEPS = 1;
 
   postInstall = ''