artifact-builder: use testers.invalidateFetcherByDrvHash to ensure output hash validity #25
+27
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winterqt
commented
Sep 17, 2025
…tput hash validity As discussed at NixCon, now a simple building of the drvs will check that the output hashes are all correct!
winterqt
force-pushed
the
push-kquyuqrokotp
branch
from
609ca0b to
2ea14e9
Compare
Member
|
Focusing just on the FODs Changes made to force a hash mismatch. % git diff
diff --git a/package-sets/python-packages/nixoslogo/nixoslogo/logomark.py b/package-sets/python-packages/nixoslogo/nixoslogo/logomark.py
index 3a8d89d..20233af 100644
--- a/package-sets/python-packages/nixoslogo/nixoslogo/logomark.py
+++ b/package-sets/python-packages/nixoslogo/nixoslogo/logomark.py
@@ -117,7 +117,7 @@ class Lambda(BaseRenderable):
]
# Need to negate the y-axis so the lambda is not upside down
- points = Points([Point((point.x, -point.y)) for point in points])
+ points = Points([Point((round(point.x, 3), round(-point.y, 3))) for point in points])
return points
def make_named_lambda_points(After the changes to the source code. Not sure why it's only showing 82/83 failures instead of 96. 2 + 8 + 22 + 44 + 1 + 5 = 82 |
Member
|
Oh duh I need to mess up the logotype module as well for SVG files that are just the logotype. % git diff
diff --git a/package-sets/python-packages/nixoslogo/nixoslogo/logomark.py b/package-sets/python-packages/nixoslogo/nixoslogo/logomark.py
index 3a8d89d..20233af 100644
--- a/package-sets/python-packages/nixoslogo/nixoslogo/logomark.py
+++ b/package-sets/python-packages/nixoslogo/nixoslogo/logomark.py
@@ -117,7 +117,7 @@ class Lambda(BaseRenderable):
]
# Need to negate the y-axis so the lambda is not upside down
- points = Points([Point((point.x, -point.y)) for point in points])
+ points = Points([Point((round(point.x, 3), round(-point.y, 3))) for point in points])
return points
def make_named_lambda_points(
diff --git a/package-sets/python-packages/nixoslogo/nixoslogo/logotype.py b/package-sets/python-packages/nixoslogo/nixoslogo/logotype.py
index cf5c39f..76865f8 100644
--- a/package-sets/python-packages/nixoslogo/nixoslogo/logotype.py
+++ b/package-sets/python-packages/nixoslogo/nixoslogo/logotype.py
@@ -193,7 +193,7 @@ class Glyph(BaseRenderable):
points_bezier = [
elem
for pair in (
- (point.x, point.y)
+ (point.x, point.y + 0.001)
for point in (points.pop(0) for _ in range(2))
)
for elem in pair
@@ -206,7 +206,7 @@ class Glyph(BaseRenderable):
points_bezier = [
elem
for pair in (
- (point.x, point.y)
+ (point.x, point.y + 0.001)
for point in (points.pop(0) for _ in range(3))
)
for elem in pairThere we go. Everything fails as expected. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at NixCon, now a simple building of the drvs will check that the output hashes are all correct!