Fixes

Author: dries-c

.gitignore

@@ -1,2 +1,2 @@
-.idea/
-vendor/
+/vendor
+/composer.lock

src/muqsit/invmenu/InvMenuEventHandler.php

@@ -4,7 +4,6 @@
 
 namespace muqsit\invmenu;
 
-use muqsit\invmenu\inventory\InvMenuInventory;
 use muqsit\invmenu\session\network\PlayerNetwork;
 use muqsit\invmenu\session\PlayerManager;
 use muqsit\invmenu\session\PlayerWindowDispatcher;

src/muqsit/invmenu/session/network/handler/PlayerNetworkHandlerRegistry.php

@@ -20,7 +20,7 @@ final class PlayerNetworkHandlerRegistry{
 	public function __construct(){
 		$this->registerDefault(new ClosurePlayerNetworkHandler(static function(Closure $then, int $protocolId) : NetworkStackLatencyEntry{
 			$timestamp = mt_rand();
-			return new NetworkStackLatencyEntry($timestamp * ($protocolId >= ProtocolInfo::PROTOCOL_1_20_10 ? 1000000 : 1000), $then, $timestamp * ($protocolId >= ProtocolInfo::PROTOCOL_1_20_10 ? 1 : 1000));
+			return new NetworkStackLatencyEntry($timestamp * ($protocolId >= ProtocolInfo::PROTOCOL_1_20_10 ? 1000000 : 1000), $then, $timestamp);
 		}));
 		$this->register(DeviceOS::PLAYSTATION, new ClosurePlayerNetworkHandler(static function(Closure $then, int $protocolId) : NetworkStackLatencyEntry{
 			$timestamp = mt_rand();

src/muqsit/invmenu/type/BlockActorFixedInvMenuType.php

@@ -35,7 +35,7 @@ public function getSize() : int{
 
 	public function createGraphic(InvMenu $menu, Player $player) : ?InvMenuGraphic{
 		$position = $player->getPosition();
-		$origin = $position->addVector(InvMenuTypeHelper::getPositionOffset())->floor();
+		$origin = $position->addVector(InvMenuTypeHelper::getBehindPositionOffset())->floor();
 		if(!InvMenuTypeHelper::isValidYCoordinate($origin->y)){
 			return null;
 		}

src/muqsit/invmenu/type/BlockFixedInvMenuType.php

@@ -27,7 +27,7 @@ public function getSize() : int{
 	}
 
 	public function createGraphic(InvMenu $menu, Player $player) : ?InvMenuGraphic{
-		$origin = $player->getPosition()->addVector(InvMenuTypeHelper::getPositionOffset())->floor();
+		$origin = $player->getPosition()->addVector(InvMenuTypeHelper::getBehindPositionOffset())->floor();
 		if(!InvMenuTypeHelper::isValidYCoordinate($origin->y)){
 			return null;
 		}

src/muqsit/invmenu/type/DoublePairableBlockActorFixedInvMenuType.php

@@ -35,7 +35,7 @@ public function getSize() : int{
 
 	public function createGraphic(InvMenu $menu, Player $player) : ?InvMenuGraphic{
 		$position = $player->getPosition();
-		$origin = $position->addVector(InvMenuTypeHelper::getPositionOffset())->floor();
+		$origin = $position->addVector(InvMenuTypeHelper::getBehindPositionOffset())->floor();
 		if(!InvMenuTypeHelper::isValidYCoordinate($origin->y)){
 			return null;
 		}

src/muqsit/invmenu/type/graphic/BlockInvMenuGraphic.php

@@ -31,7 +31,7 @@ public function send(Player $player, ?string $name) : void{
 
 		$network->sendDataPacket(UpdateBlockPacket::create(
 			BlockPosition::fromVector3($this->position),
-            TypeConverter::getInstance($network->getProtocolId())->getBlockTranslator()->internalIdToNetworkId($this->block->getStateId()),
+			TypeConverter::getInstance($network->getProtocolId())->getBlockTranslator()->internalIdToNetworkId($this->block->getStateId()),
 			UpdateBlockPacket::FLAG_NETWORK,
 			UpdateBlockPacket::DATA_LAYER_NORMAL
 		));
@@ -43,7 +43,6 @@ public function sendInventory(Player $player, Inventory $inventory) : bool{
 
 	public function remove(Player $player) : void{
 		$network = $player->getNetworkSession();
-
 		foreach($player->getWorld()->createBlockUpdatePackets($network->getTypeConverter(), [$this->position]) as $packet){
 			$network->sendDataPacket($packet);
 		}

src/muqsit/invmenu/type/util/InvMenuTypeHelper.php

@@ -15,7 +15,7 @@ final class InvMenuTypeHelper{
 	public const NETWORK_WORLD_Y_MIN = -64;
 	public const NETWORK_WORLD_Y_MAX = 320;
 
-	public static function getPositionOffset() : Vector3{
+	public static function getBehindPositionOffset() : Vector3{
 		return new Vector3(0, -2, 0);
 	}