Skip to content
This repository was archived by the owner on Jun 5, 2023. It is now read-only.

global whitelist not applied to historical matches for which use case has been removed #454

@daanraman

Description

@daanraman

Reproduce:

  • Add whitelist item in global whitelist section (literals for example)
  • Remove use case from the configuration file
  • Save configuration file so that historical whitelist is processed

Since the use case can't be found anymore for the hits we want to remove, the global whitelist is also ignored (break statement):

# Extract information and get analyzer linked to this outlier
                    model_name = doc["_source"]["outliers"]["model_name"][i]
                    model_type = doc["_source"]["outliers"]["model_type"][i]
                    config_section_name = model_type + "_" + model_name
                    if config_section_name not in dict_with_analyzer:
                        self.logging.logger.debug("Outlier '" + config_section_name + "' " +
                                                    " haven't been found in configuration, could not check whitelist")
                        break  # If one outlier is not whitelisted, we keep all other outliers

For outlier hits for which the generating use case has been deleted, the global whitelist (literals and regexp) should still be applied.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions