fix: address Copilot review feedback

- Restore Holodeck to v0.2.18 matching the original ci.yaml
- Remove unused operator_version input from release workflow and caller
- Skip Slack notification when SLACK_BOT_TOKEN secret is not configured

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

Author: ArangoGutierrez

.github/workflows/ci.yaml

@@ -62,6 +62,5 @@ jobs:
     uses: ./.github/workflows/release.yaml
     with:
       commit_short_sha: ${{ needs.variables.outputs.commit_short_sha }}
-      operator_version: ${{ needs.variables.outputs.operator_version }}
       operator_image_base: ${{ needs.variables.outputs.operator_image_base }}
     secrets: inherit

.github/workflows/e2e-tests.yaml

@@ -73,7 +73,7 @@ jobs:
           name: values-overrides
           path: ${{ github.workspace }}
       - name: Set up Holodeck
-        uses: NVIDIA/[email protected].17
+        uses: NVIDIA/[email protected].18
         with:
           aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }}
           aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
@@ -134,7 +134,7 @@ jobs:
           name: values-overrides
           path: ${{ github.workspace }}
       - name: Set up Holodeck
-        uses: NVIDIA/[email protected].17
+        uses: NVIDIA/[email protected].18
         with:
           aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }}
           aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

.github/workflows/forward-compatibility.yaml

@@ -77,7 +77,7 @@ jobs:
   notify-failure:
     runs-on: ubuntu-latest
     needs: [fetch-latest-images, run-e2e-tests]
-    if: ${{ always() && (needs.fetch-latest-images.result == 'failure' || needs.run-e2e-tests.result == 'failure') }}
+    if: ${{ always() && (needs.fetch-latest-images.result == 'failure' || needs.run-e2e-tests.result == 'failure') && secrets.SLACK_BOT_TOKEN != '' }}
     steps:
       - name: Send Slack alert notification
         uses: slackapi/[email protected]

.github/workflows/release.yaml

@@ -23,9 +23,6 @@ on:
       commit_short_sha:
         required: true
         type: string
-      operator_version:
-        required: true
-        type: string
       operator_image_base:
         required: true
         type: string