Skip to content

Commit cb8f94e

Browse files
committed
Revert "Add grpo loop functional test (#2403)"
This reverts commit f5531b0.
1 parent f5531b0 commit cb8f94e

File tree

8 files changed

+1349
-2136
lines changed

8 files changed

+1349
-2136
lines changed

examples/rl/environment_configs/countdown.yaml

Lines changed: 0 additions & 3 deletions
This file was deleted.

pyproject.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ dev = [
8585
"flashinfer-python",
8686
"wget",
8787
"onnxscript",
88-
"datasets",
8988
]
9089

9190
lts = [
@@ -104,7 +103,6 @@ lts = [
104103
"flashinfer-python",
105104
"wget",
106105
"onnxscript",
107-
"datasets",
108106
]
109107

110108
[dependency-groups]

tests/functional_tests/python_test_utils/test_grpo_training_loop.py

Lines changed: 0 additions & 58 deletions
This file was deleted.

tests/functional_tests/shell_test_utils/run_ci_test.sh

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -314,24 +314,6 @@ for i in $(seq 1 $N_REPEAT); do
314314
fi
315315
fi
316316

317-
# For rl jobs
318-
if [[ "$MODE" == "rl" && ("$TRAINING_EXIT_CODE" -eq 0 || "$TEST_TYPE" == "release") ]]; then
319-
if [[ "$TEST_TYPE" == "frozen-start" ]]; then
320-
TRAIN_ITERS=$(cat $TRAINING_PARAMS_PATH |
321-
/usr/local/bin/yq '.MODEL_ARGS."--exit-interval" // "50"')
322-
uv run --no-sync python $ROOT_DIR/tests/functional_tests/python_test_utils/get_test_results_from_tensorboard_logs.py \
323-
--logs-dir $TENSORBOARD_PATH \
324-
--train-iters $TRAIN_ITERS \
325-
--output-path ${OUTPUT_PATH}/$(basename $GOLDEN_VALUES_PATH) \
326-
"${EXTRACT_ARGS[@]}"
327-
uv run --no-sync pytest -s -o log_cli=true --log-cli-level=info $ROOT_DIR/tests/functional_tests/python_test_utils/test_grpo_training_loop.py \
328-
--golden-values-path $GOLDEN_VALUES_PATH \
329-
--test-values-path ${OUTPUT_PATH}/$(basename $GOLDEN_VALUES_PATH) \
330-
--model-config-path ${TRAINING_PARAMS_PATH} \
331-
$ALLOW_NONDETERMINISTIC_ALGO_ARG
332-
fi
333-
fi
334-
335317
# Abort if training failed
336318
if [[ "$TRAINING_EXIT_CODE" -ne 0 && "$TEST_TYPE" != "release" ]]; then
337319
echo "Training failed. Aborting."

tests/functional_tests/test_cases/gpt/gpt_grpo_tp1_pp1_dp8_583m_throughputtest/golden_values_dev_dgx_h100.json

Lines changed: 0 additions & 287 deletions
This file was deleted.

0 commit comments

Comments
 (0)