Skip to content

Commit 1a2b6d2

Browse files
committed
test: align engine tests with native jinja default
- opt the ginja mixin regression tests into the hardened renderer explicitly now that RunConfig defaults engine rendering to native - update the image empty-prompt assertion to expect the native-mode ValueError surfaced by the generator Signed-off-by: Eric W. Tramel <[email protected]>
1 parent 094c58b commit 1a2b6d2

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

packages/data-designer-engine/tests/engine/column_generators/generators/test_image.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
from data_designer.config.models import ImageContext, ImageFormat, ModalityDataType
1111
from data_designer.engine.column_generators.generators.base import GenerationStrategy
1212
from data_designer.engine.column_generators.generators.image import ImageCellGenerator
13-
from data_designer.engine.processing.ginja.exceptions import UserTemplateError
1413

1514

1615
@pytest.fixture
@@ -114,13 +113,13 @@ def test_image_cell_generator_missing_columns_error(stub_image_column_config, st
114113

115114

116115
def test_image_cell_generator_empty_prompt_error(stub_resource_provider):
117-
"""Test that empty rendered prompt raises UserTemplateError."""
116+
"""Test that empty rendered prompt raises ValueError in native mode."""
118117
# Create config with template that renders to empty string
119118
config = ImageColumnConfig(name="test_image", prompt="{{ empty }}", model_alias="test_model")
120119

121120
generator = ImageCellGenerator(config=config, resource_provider=stub_resource_provider)
122121

123-
with pytest.raises(UserTemplateError):
122+
with pytest.raises(ValueError, match="empty"):
124123
generator.generate(data={"empty": ""})
125124

126125

packages/data-designer-engine/tests/engine/processing/ginja/test_environment.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
import pytest
55

6+
from data_designer.config.run_config import JinjaRenderingEngine
67
from data_designer.engine.processing.ginja.environment import (
78
ALLOWED_JINJA_FILTERS,
89
UserTemplateSandboxEnvironment,
@@ -180,6 +181,7 @@ def test_with_jinja2_user_template_rendering_mixin(test_case, template_1, templa
180181

181182
class Foo(WithJinja2UserTemplateRendering):
182183
def __init__(self, template_1: str, template_2: str = None):
184+
self._jinja_rendering_engine = JinjaRenderingEngine.GINJA
183185
if template_2 is None:
184186
# Single template
185187
self.prepare_jinja2_template_renderer(template_1, dataset_variables=["safe"])

0 commit comments

Comments
 (0)