-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Labels
EnhancementNew feature or requestNew feature or requestRefactorTechnical internal work to improve systemsTechnical internal work to improve systems
Description
Code in QuantityFactory allocate a temporary Quantity to build the Halo Specification used for exchange. This code will then create the spec based on that Quantity but will allow divergence from the default number of halo points.
We put a warning in the halo_spec function because we weren't sure that was needed.
Code in pyfv3.dyn_core has a legit case of a 3-halo allocated Quantity requiring a 2-halo exchange.
This entire system is duct tape upon duct tape and need refactor.
First steps:
- Do away with the warning
- Rely on own quantity for
halo_specrather than a temporary allocation - Deprecate than remove
QuantityFactory.get_quantity_halo_spec
Going deeper - requiring orchestration-worthy system:
-
WrappedHaloUpdaterneeds to go -
HaloUpdaterbased on previously cachedQuantityneeds to go
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
EnhancementNew feature or requestNew feature or requestRefactorTechnical internal work to improve systemsTechnical internal work to improve systems