-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Labels
EnhancementNew feature or requestNew feature or requestRefactorTechnical internal work to improve systemsTechnical internal work to improve systems
Description
Description
This originally came up out of PR #246, which is related to Issue #64.
While trying to clean up the soon-to-be-removed NDSL Namelist, we needed a way to extract grid parameters from a namelist file. A simple dict was used to move forward, but it really makes sense to have a class replace that.
Potential solution
Currently, in the translate tests (conftest.py), we do something like the following to create a dict to eventually use to initialize the grid:
grid_params = grid_params_from_f90nml(namelist)
Rather than return a dict, a potential class could be (suggestion from @romanc and @FlorianDeconinck):
class CartesianGridConfig
nx: int,
ny: int,
nz: int,
class CubeSphereGridConfig:
layout: tuple[int, int]
cartesian_dims: CartesianGridConfigReactions are currently unavailable
Metadata
Metadata
Assignees
Labels
EnhancementNew feature or requestNew feature or requestRefactorTechnical internal work to improve systemsTechnical internal work to improve systems