deparameterize terraform state bucket

JamesW1-NHS · JamesW1-NHS · commit 999a5622de8a · 2026-01-22T18:07:22.000Z
diff --git a/infrastructure/grafana/non-prod/terraform/.terraform.lock.hcl b/infrastructure/grafana/non-prod/terraform/.terraform.lock.hcl
diff --git a/infrastructure/grafana/non-prod/terraform/Makefile b/infrastructure/grafana/non-prod/terraform/Makefile
@@ -5,7 +5,7 @@ region              ?= $(AWS_REGION)
 
 tf_cmd = AWS_PROFILE=$(AWS_PROFILE) terraform
 
-bucket_name = immunisation-$(environment)-grafana-terraform-state
+bucket_name = immunisation-grafana-terraform-state
 state_key=state/$(environment)/terraform.tfstate
 
 tf_state = \
diff --git a/infrastructure/grafana/non-prod/terraform/grafana.tf b/infrastructure/grafana/non-prod/terraform/grafana.tf
@@ -1,6 +1,6 @@
-# S3 state bucket
+# S3 state bucket - NB this is not parameterized
 resource "aws_s3_bucket" "grafana_tf_state_bucket" {
-  bucket = "immunisation-${var.environment}-grafana-terraform-state"
+  bucket = "immunisation-grafana-terraform-state"
   region = var.aws_region
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`		`-# S3 state bucket`
	`1`	`+# S3 state bucket - NB this is not parameterized`
`2`	`2`	`resource "aws_s3_bucket" "grafana_tf_state_bucket" {`
`3`		`- bucket = "immunisation-${var.environment}-grafana-terraform-state"`
	`3`	`+ bucket = "immunisation-grafana-terraform-state"`
`4`	`4`	`region = var.aws_region`
`5`	`5`	`}`
`6`	`6`