VED-879: Fix Sonar issue ignore filters (#1223)

* corrected issue.ignore filters

* S7494

* S7494 II

* kick

* kick

* kick

Author: JamesW1-NHS

lambdas/backend/src/search_imms_handler.py

@@ -30,7 +30,7 @@ def search_imms(event: APIGatewayProxyEventV1, controller: FhirController):
     )
     parser.add_argument(
         "--immunization.target",
-        help="http://hl7.org/fhir/ValueSet/immunization-target-disease",  # NOSONAR(S5332)
+        help="http://hl7.org/fhir/ValueSet/immunization-target-disease",
         type=str,
         required=True,
         nargs="+",

lambdas/delta_backend/src/extractor.py

@@ -14,7 +14,7 @@ class Extractor:
     )
     EXTENSION_URL_SCT_DESC_DISPLAY = "https://fhir.hl7.org.uk/StructureDefinition/Extension-UKCore-CodingSCTDescDisplay"
 
-    CODING_SYSTEM_URL_SNOMED = "http://snomed.info/sct"  # NOSONAR(S5332) this is a code system descriptor, not a URL
+    CODING_SYSTEM_URL_SNOMED = "http://snomed.info/sct"
     ODS_ORG_CODE_SYSTEM_URL = "https://fhir.nhs.uk/Id/ods-organization-code"
     DEFAULT_LOCATION = "X99999"
     NHS_NUMBER_SYSTEM_URL = "https://fhir.nhs.uk/Id/nhs-number"

lambdas/id_sync/src/pds_details.py

@@ -12,7 +12,7 @@
 from os_vars import get_pds_env
 
 pds_env = get_pds_env()
-safe_tmp_dir = tempfile.mkdtemp(dir="/tmp")  # NOSONAR(S5443)
+safe_tmp_dir = tempfile.mkdtemp(dir="/tmp")
 
 
 # Get Patient details from external service PDS using NHS number from MNS notification

lambdas/mesh_processor/src/converter.py

@@ -11,15 +11,13 @@
 
 
 def parse_headers(headers_str: str) -> dict[str, str]:
-    headers = dict(  # NOSONAR(S7494) force this to dict
-        header_str.split(":", 1) for header_str in headers_str.split("\r\n") if ":" in header_str
-    )
+    headers = dict(header_str.split(":", 1) for header_str in headers_str.split("\r\n") if ":" in header_str)
     return {k.strip(): v.strip() for k, v in headers.items()}
 
 
 def parse_header_value(header_value: str) -> tuple[str, dict[str, str]]:
     main_value, *params = header_value.split(";")
-    parsed_params = dict(param.strip().split("=", 1) for param in params)  # NOSONAR(S7494) force this to dict
+    parsed_params = dict(param.strip().split("=", 1) for param in params)
     parsed_params = {k: v.strip('"') for k, v in parsed_params.items()}
     return main_value, parsed_params
 

lambdas/mns_subscription/src/mns_setup.py

@@ -12,7 +12,7 @@
 
 def get_mns_service(mns_env: str = "int"):
     boto_config = Config(region_name="eu-west-2")
-    cache = Cache(directory="/tmp")  # NOSONAR(S5443)
+    cache = Cache(directory="/tmp")
     logging.info("Creating authenticator...")
     # TODO: MNS and PDS need separate secrets
     authenticator = AppRestrictedAuth(

lambdas/shared/src/common/models/constants.py

@@ -67,7 +67,7 @@ class Urls:
 
     NHS_NUMBER = "https://fhir.nhs.uk/Id/nhs-number"
     VACCINATION_PROCEDURE = "https://fhir.hl7.org.uk/StructureDefinition/Extension-UKCore-VaccinationProcedure"
-    SNOMED = "http://snomed.info/sct"  # NOSONAR(S5332)
+    SNOMED = "http://snomed.info/sct"
     NHS_NUMBER_VERIFICATION_STATUS_STRUCTURE_DEFINITION = (
         "https://fhir.hl7.org.uk/StructureDefinition/Extension-UKCore-NHSNumberVerificationStatus"
     )
@@ -76,7 +76,7 @@ class Urls:
     )
     ODS_ORGANIZATION_CODE = "https://fhir.nhs.uk/Id/ods-organization-code"
     URN_SCHOOL_NUMBER = "https://fhir.hl7.org.uk/Id/urn-school-number"
-    NULL_FLAVOUR_CODES = "http://terminology.hl7.org/CodeSystem/v3-NullFlavor"  # NOSONAR(S5332)
+    NULL_FLAVOUR_CODES = "http://terminology.hl7.org/CodeSystem/v3-NullFlavor"
 
 
 class RedisHashKeys:

sonar-project.properties

@@ -7,11 +7,10 @@ sonar.exclusions=**/proxies/**,**/utilities/scripts/**,**/infrastructure/account
 sonar.coverage.exclusions=lambdas/shared/src/common/models/batch_constants.py
 sonar.python.coverage.reportPaths=backend-coverage.xml,delta-coverage.xml,ack-lambda-coverage.xml,filenameprocessor-coverage.xml,recordforwarder-coverage.xml,recordprocessor-coverage.xml,mesh_processor-coverage.xml,redis_sync-coverage.xml,mns_subscription-coverage.xml,id_sync-coverage.xml,shared-coverage.xml,batchprocessorfilter-coverage.xml
 sonar.cpd.exclusions=**/Dockerfile
-sonar.issue.ignore.multicriteria=exclude_snomed_urls,exclude_hl7_urls
-sonar.issue.ignore.multicriteria.exclude_snomed_urls.ruleKey=python:S5332
-sonar.issue.ignore.multicriteria.exclude_snomed_urls.resourceKey=**http://snomed\.info/sct**
-sonar.issue.ignore.multicriteria.exclude_hl7_urls.ruleKey=python:S5332
-sonar.issue.ignore.multicriteria.exclude_hl7_urls.resourceKey=**http://terminology\.hl7\.org/CodeSystem/v3-NullFlavor**
-sonar.issue.ignore.multicriteria=e1
-sonar.issue.ignore.multicriteria.e1.ruleKey=python:S5443
-sonar.issue.ignore.multicriteria.e1.resourceKey=**/mns_setup.py
+sonar.issue.ignore.multicriteria=exclude_http_urls,exclude_writable_dirs,exclude_force_dict
+sonar.issue.ignore.multicriteria.exclude_http_urls.ruleKey=python:S5332
+sonar.issue.ignore.multicriteria.exclude_http_urls.resourceKey=**/lambdas/**
+sonar.issue.ignore.multicriteria.exclude_writable_dirs.ruleKey=python:S5443
+sonar.issue.ignore.multicriteria.exclude_writable_dirs.resourceKey=**/lambdas/**
+sonar.issue.ignore.multicriteria.exclude_force_dict.ruleKey=python:S7494
+sonar.issue.ignore.multicriteria.exclude_force_dict.resourceKey=**/lambdas/**