Move prihits.empty() guard before nover computation in SelectSameTrack

Copilot · oksuzian · web-flow · commit 8fd3bcf5ca41 · 2026-04-07T13:49:48.000Z
Agent-Logs-Url: https://github.com/Mu2e/Offline/sessions/f9f302df-5ed3-439e-8046-3c5c0c6a940e Co-authored-by: oksuzian <48927306+oksuzian@users.noreply.github.com>
diff --git a/TrkReco/src/SelectSameTrack_module.cc b/TrkReco/src/SelectSameTrack_module.cc
@@ -140,11 +140,11 @@ namespace mu2e {
                   for(auto const& hit: priks.hits()){
                     if(hit._ambig > WireHitState::inactive)prihits.insert(hit._index);
                   }
+                  if(prihits.empty()) continue;
                   unsigned nover(0);
                   for(auto const& hit: secks.hits()){
                     if(hit._ambig > WireHitState::inactive && prihits.find(hit._index) != prihits.end())++nover;
                   }
-                  if(prihits.empty()) continue;
                   double hfrac = float(nover)/float(prihits.size());
                   if(debug_ > 2) std::cout << "Hit overlap " << hfrac << std::endl;
                   if(hfrac > minhf_){

Original file line number	Diff line number	Diff line change
`@@ -140,11 +140,11 @@ namespace mu2e {`
`140`	`140`	`for(auto const& hit: priks.hits()){`
`141`	`141`	`if(hit._ambig > WireHitState::inactive)prihits.insert(hit._index);`
`142`	`142`	`}`
	`143`	`+ if(prihits.empty()) continue;`
`143`	`144`	`unsigned nover(0);`
`144`	`145`	`for(auto const& hit: secks.hits()){`
`145`	`146`	`if(hit._ambig > WireHitState::inactive && prihits.find(hit._index) != prihits.end())++nover;`
`146`	`147`	`}`
`147`		`- if(prihits.empty()) continue;`
`148`	`148`	`double hfrac = float(nover)/float(prihits.size());`
`149`	`149`	`if(debug_ > 2) std::cout << "Hit overlap " << hfrac << std::endl;`
`150`	`150`	`if(hfrac > minhf_){`