From b2acb04ec460339d7dc4945ea26a70955af847a9 Mon Sep 17 00:00:00 2001 From: Manuel Martin Date: Mon, 15 Jun 2020 14:45:07 +0200 Subject: [PATCH] Fix back/forth URL bar selection ranges --- .../org/mozilla/vrbrowser/ui/views/NavigationURLBar.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/views/NavigationURLBar.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/views/NavigationURLBar.java index f5a51f263..65dba9228 100644 --- a/app/src/common/shared/org/mozilla/vrbrowser/ui/views/NavigationURLBar.java +++ b/app/src/common/shared/org/mozilla/vrbrowser/ui/views/NavigationURLBar.java @@ -527,7 +527,12 @@ private void showSelectionMenu() { public void onAction(String action) { int startSelection = mBinding.urlEditText.getSelectionStart(); int endSelection = mBinding.urlEditText.getSelectionEnd(); - boolean selectionValid = endSelection > startSelection; + boolean selectionValid = endSelection != startSelection; + if (startSelection > endSelection) { + int tmp = endSelection; + endSelection = startSelection; + startSelection = tmp; + } if (action.equals(GeckoSession.SelectionActionDelegate.ACTION_CUT) && selectionValid) { String selectedText = mBinding.urlEditText.getText().toString().substring(startSelection, endSelection);