Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Commit 4bb48a8

Browse files
keianhzobluemarvin
keianhzo
authored and
bluemarvin
committed
Increase click target size for buttons inside Library views (#1873)
* Increase click target size for buttons inside Library views * Rebase fixes
1 parent 9e35425 commit 4bb48a8

5 files changed

Lines changed: 21 additions & 22 deletions

File tree

‎app/src/common/shared/org/mozilla/vrbrowser/ui/views/LibraryItemContextMenu.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,14 +104,14 @@ public int getMenuHeight() {
104104
case BOOKMARKS:
105105
mBinding.bookmarkLayout.setVisibility(GONE);
106106
mBinding.newWindowLayout.setBackgroundResource(R.drawable.library_context_menu_item_background_single);
107-
return WidgetPlacement.dpDimension(getContext(), R.dimen.library_item_row_height);
107+
return WidgetPlacement.dpDimension(getContext(), R.dimen.library_context_menu_height);
108108
case HISTORY:
109109
mBinding.bookmarkLayout.setVisibility(VISIBLE);
110110
mBinding.newWindowLayout.setBackgroundResource(R.drawable.library_context_menu_item_background_top);
111-
return WidgetPlacement.dpDimension(getContext(), R.dimen.library_item_row_height) * 2;
111+
return WidgetPlacement.dpDimension(getContext(), R.dimen.library_context_menu_height) * 2;
112112
}
113113

114-
return WidgetPlacement.dpDimension(getContext(), R.dimen.library_item_row_height) * 2;
114+
return WidgetPlacement.dpDimension(getContext(), R.dimen.library_context_menu_height) * 2;
115115
}
116116

117117
}

‎app/src/main/res/layout/bookmark_item.xml‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,12 @@
9595

9696
<ImageView
9797
android:id="@+id/trash"
98-
android:layout_width="22dp"
99-
android:layout_height="22dp"
98+
android:layout_width="@dimen/library_item_row_height"
99+
android:layout_height="@dimen/library_item_row_height"
100100
android:layout_gravity="center_vertical|end"
101-
android:layout_marginEnd="10dp"
102101
android:focusable="false"
103102
android:focusableInTouchMode="false"
104-
android:padding="@dimen/settings_icon_padding_max"
103+
android:padding="@dimen/library_icon_padding_max"
105104
android:soundEffectsEnabled="false"
106105
android:src="@drawable/ic_icon_trash"
107106
android:tint="@color/library_panel_icon_color"
@@ -110,12 +109,12 @@
110109

111110
<ImageView
112111
android:id="@+id/more"
113-
android:layout_width="22dp"
114-
android:layout_height="22dp"
112+
android:layout_width="@dimen/library_item_row_height"
113+
android:layout_height="@dimen/library_item_row_height"
115114
android:layout_gravity="center_vertical|end"
116115
android:focusable="false"
117116
android:focusableInTouchMode="false"
118-
android:padding="@dimen/settings_icon_padding_max"
117+
android:padding="@dimen/library_icon_padding_max"
119118
android:soundEffectsEnabled="false"
120119
android:src="@drawable/ic_icon_more_options"
121120
android:tint="@color/library_panel_icon_color"

‎app/src/main/res/layout/history_item.xml‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -108,13 +108,12 @@
108108

109109
<ImageView
110110
android:id="@+id/trash"
111-
android:layout_width="22dp"
112-
android:layout_height="22dp"
111+
android:layout_width="@dimen/library_item_row_height"
112+
android:layout_height="@dimen/library_item_row_height"
113113
android:layout_gravity="center_vertical|end"
114-
android:layout_marginEnd="10dp"
115114
android:focusable="false"
116115
android:focusableInTouchMode="false"
117-
android:padding="@dimen/settings_icon_padding_max"
116+
android:padding="@dimen/library_icon_padding_max"
118117
android:soundEffectsEnabled="false"
119118
android:src="@drawable/ic_icon_trash"
120119
android:tint="@color/library_panel_icon_color"
@@ -123,12 +122,12 @@
123122

124123
<ImageView
125124
android:id="@+id/more"
126-
android:layout_width="22dp"
127-
android:layout_height="22dp"
125+
android:layout_width="@dimen/library_item_row_height"
126+
android:layout_height="@dimen/library_item_row_height"
128127
android:layout_gravity="center_vertical|end"
129128
android:focusable="false"
130129
android:focusableInTouchMode="false"
131-
android:padding="@dimen/settings_icon_padding_max"
130+
android:padding="@dimen/library_icon_padding_max"
132131
android:soundEffectsEnabled="false"
133132
android:src="@drawable/ic_icon_more_options"
134133
android:tint="@color/library_panel_icon_color"

‎app/src/main/res/layout/library_item_context_menu.xml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<FrameLayout
2727
android:id="@+id/new_window_layout"
2828
android:layout_width="match_parent"
29-
android:layout_height="@dimen/library_item_row_height"
29+
android:layout_height="@dimen/library_context_menu_height"
3030
android:padding="15dp"
3131
android:background="@drawable/library_context_menu_item_background_top"
3232
android:clickable="true"
@@ -58,7 +58,7 @@
5858
<FrameLayout
5959
android:id="@+id/bookmark_layout"
6060
android:layout_width="match_parent"
61-
android:layout_height="@dimen/library_item_row_height"
61+
android:layout_height="@dimen/library_context_menu_height"
6262
android:padding="15dp"
6363
android:background="@drawable/library_context_menu_item_background_bottom"
6464
android:clickable="true"

‎app/src/main/res/values/dimen.xml‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -198,13 +198,13 @@
198198
<dimen name="settings_icon_padding_min">0dp</dimen>
199199

200200
<!-- Library -->
201-
<dimen name="library_item_row_height">55dp</dimen>
201+
<dimen name="library_item_row_height">38dp</dimen>
202202
<dimen name="library_section_text_size">18sp</dimen>
203203
<dimen name="library_item_title_text_size">20sp</dimen>
204204
<dimen name="library_item_url_text_size">16sp</dimen>
205205
<dimen name="library_item_date_text_size">16sp</dimen>
206-
<dimen name="library_icon_padding_max">2dp</dimen>
207-
<dimen name="library_icon_padding_min">0dp</dimen>
206+
<dimen name="library_icon_padding_max">10dp</dimen>
207+
<dimen name="library_icon_padding_min">8dp</dimen>
208208
<dimen name="library_notification_font_size">13sp</dimen>
209209

210210
<!-- Language -->
@@ -219,6 +219,7 @@
219219

220220
<!-- Library Menu -->
221221
<dimen name="library_context_menu_width">320dp</dimen>
222+
<dimen name="library_context_menu_height">55dp</dimen>
222223
<dimen name="library_context_menu_top_margin">4dp</dimen>
223224
<item name="library_context_menu_z_distance" format="float" type="dimen">0.12</item>
224225

0 commit comments

Comments
 (0)