Avoid to recompute getLanguages at every extensionExistsForLanguage call

Hélios GILLES · Hélios GILLES · commit 082db77c14d5 · 2025-06-10T11:16:02.000+02:00
diff --git a/org.moreunit.core/src/org/moreunit/core/extension/LanguageExtensionManager.java b/org.moreunit.core/src/org/moreunit/core/extension/LanguageExtensionManager.java
@@ -31,16 +31,18 @@ public class LanguageExtensionManager
 
     private final BundleContext bundleContext;
     private final Logger logger;
+    private final Collection<Language> languages;
 
     public LanguageExtensionManager(BundleContext bundleContext, Logger logger)
     {
         this.bundleContext = bundleContext;
         this.logger = logger;
+        this.languages = getLanguages();
     }
 
     public boolean extensionExistsForLanguage(String langId)
     {
-        return getLanguages().contains(new Language(langId));
+        return languages.contains(new Language(langId));
     }
 
     private Collection<Language> getLanguages()

Original file line number	Diff line number	Diff line change
`@@ -31,16 +31,18 @@ public class LanguageExtensionManager`
`31`	`31`
`32`	`32`	`private final BundleContext bundleContext;`
`33`	`33`	`private final Logger logger;`
	`34`	`+ private final Collection<Language> languages;`
`34`	`35`
`35`	`36`	`public LanguageExtensionManager(BundleContext bundleContext, Logger logger)`
`36`	`37`	`{`
`37`	`38`	`this.bundleContext = bundleContext;`
`38`	`39`	`this.logger = logger;`
	`40`	`+ this.languages = getLanguages();`
`39`	`41`	`}`
`40`	`42`
`41`	`43`	`public boolean extensionExistsForLanguage(String langId)`
`42`	`44`	`{`
`43`		`- return getLanguages().contains(new Language(langId));`
	`45`	`+ return languages.contains(new Language(langId));`
`44`	`46`	`}`
`45`	`47`
`46`	`48`	`private Collection<Language> getLanguages()`