Merge pull request #2452 from bagerard/github_actions_improvements

improve github actions

Author: bagerard

.github/workflows/github-actions.yml

@@ -24,6 +24,8 @@ env:
 
 jobs:
   linting:
+    # Run pre-commit (https://pre-commit.com/)
+    # which runs pre-configured linter & autoformatter
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
@@ -94,21 +96,10 @@ jobs:
         cd docs
         make html-readthedocs
 
-  irc_notification:
-    runs-on: ubuntu-latest
-    needs: [linting, test]
-    steps:
-      - uses: rectalogic/notify-irc@v1
-        if: success()
-        with:
-          channel: "irc.freenode.org#mongoengine"
-          nickname: github-notifier
-          message: |
-            Build ${{ job.status }} - ${{ github.actor }} ${{ github.event_name }} ${{ github.event.ref }}
-
   build-n-publish-dummy:
     runs-on: ubuntu-latest
-    needs: [linting, test]
+    needs: [linting, test, build_doc_dryrun]
+    if: github.event_name != 'pull_request'
     steps:
     - uses: actions/checkout@master
     - name: Set up Python 3.7
@@ -123,15 +114,14 @@ jobs:
 #      # Although working and recommended, test-pypi has a limit
 #      # in the size of projects so it's better to avoid publishing
 #      # until there is a way to garbage collect these dummy releases
-#      if: github.event_name != 'pull_request'
 #      uses: pypa/gh-action-pypi-publish@master
 #      with:
 #        password: ${{ secrets.test_pypi_token }}
 #        repository_url: https://test.pypi.org/legacy/
 
   build-n-publish:
     runs-on: ubuntu-latest
-    needs: [linting, test]
+    needs: [linting, test, build_doc_dryrun, build-n-publish-dummy]
     if: github.event_name == 'create' && startsWith(github.ref, 'refs/tags/v')
     steps:
     - uses: actions/checkout@master