Collect additional mixed_language_library output files (#3261)

Fixes
#3258.

In `xcodeproj/internal/files/output_files.bzl` using
`_collect_output_files` as a reference starts collecting more outputs in
`_collect_mixed_language_output_files` to address the issue.

I'll use
#3259 to
verify this fix is good (I will either rebase or cherry pick it here)

---------

Signed-off-by: Thiago Cruz <thiago@squareup.com>

Author: thiagohmcruz

xcodeproj/internal/files/output_files.bzl

@@ -292,28 +292,52 @@ def _collect_mixed_language_output_files(
         *,
         actions,
         compile_params_files,
+        debug_outputs,
         id,
         indexstore_overrides,
         mixed_target_infos,
-        name):
+        name,
+        output_group_info,
+        product = None,
+        swift_info,
+        transitive_infos):
     """Collects the outputs of a target.
 
     Args:
         actions: `ctx.actions`.
         compile_params_files: A `list` of compiler params `File`s that should be
             generated for Index Build and Xcode Previews.
+        debug_outputs: The `AppleDebugOutputsInfo` provider for the target, or
+            `None`.
         id: A unique identifier for the target.
         indexstore_overrides: A `list` of `(indexstore, target_name)` `tuple`s
             that override the indexstore for the target. This is used for merged
             targets.
         mixed_target_infos: A `list` of `XcodeProjInfo`s for the underlying
             Clang and Swift targets.
         name: Name (potentially replaced) of the target.
+        output_group_info: The `OutputGroupInfo` provider for the target, or
+            `None`.
+        product: A value from `process_product`.
+        swift_info: The `SwiftInfo` provider for the target, or `None`.
+        transitive_infos: A `list` of `XcodeProjInfo`s for the transitive
+            dependencies of the target.
 
     Returns:
         An opaque `struct` that should be used with `output_files.to_dto` or
         `output_files.to_output_groups_fields`.
     """
+    direct_outputs = _get_outputs(
+        debug_outputs = debug_outputs,
+        output_group_info = output_group_info,
+        product = product,
+        swift_info = swift_info,
+    )
+
+    direct_products = []
+    if direct_outputs.product:
+        direct_products.append(direct_outputs.product)
+
     transitive_indexstore_overrides = memory_efficient_depset(
         indexstore_overrides,
         transitive = [
@@ -328,6 +352,17 @@ def _collect_mixed_language_output_files(
         ],
     )
 
+    # TODO: Once BwB mode no longer has target dependencies, remove
+    # transitive products. Until then we need them, to allow `Copy Bazel
+    # Outputs` to be able to copy the products of transitive dependencies.
+    transitive_products = memory_efficient_depset(
+        direct_products,
+        transitive = [
+            info.outputs._transitive_products
+            for info in transitive_infos
+        ],
+    )
+
     transitive_compile_params = memory_efficient_depset(
         compile_params_files,
         transitive = [
@@ -357,8 +392,9 @@ def _collect_mixed_language_output_files(
             # expand to individual files and blow up the BEP. Instead they are
             # declared as inputs to `indexstores_filelist`, ensuring they are
             # downloaded as needed.
-            [indexstores_filelist]
+            [indexstores_filelist] + direct_products
         ),
+        transitive = [transitive_products],
     )
 
     direct_group_list = [

xcodeproj/internal/processed_targets/mixed_language_library_targets.bzl

@@ -1,6 +1,8 @@
 """Functions for processing mixed-language library targets."""
 
 load("@bazel_skylib//rules:common_settings.bzl", "BuildSettingInfo")
+load("@build_bazel_rules_apple//apple:providers.bzl", "AppleDebugOutputsInfo")
+load("@build_bazel_rules_swift//swift:swift.bzl", "SwiftInfo")
 load("//xcodeproj:xcodeprojinfo.bzl", "XcodeProjInfo")
 load("//xcodeproj/internal:build_settings.bzl", "get_product_module_name")
 load("//xcodeproj/internal:compilation_providers.bzl", "compilation_providers")
@@ -65,6 +67,8 @@ def _process_mixed_language_library_target(
     )
 
     objc = target[apple_common.Objc] if apple_common.Objc in target else None
+    swift_info = target[SwiftInfo] if SwiftInfo in target else None
+
     (
         target_compilation_providers,
         provider_compilation_providers,
@@ -163,17 +167,29 @@ def _process_mixed_language_library_target(
         tool = ctx.executable._target_build_settings_generator,
     )
 
+    if AppleDebugOutputsInfo in target:
+        debug_outputs = target[AppleDebugOutputsInfo]
+    else:
+        debug_outputs = None
+
     (
         target_outputs,
         provider_outputs,
         target_output_groups_metadata,
     ) = output_files.collect_mixed_language(
         actions = actions,
         compile_params_files = params_files,
+        debug_outputs = debug_outputs,
         id = id,
         indexstore_overrides = indexstore_overrides,
-        name = label.name,
         mixed_target_infos = mixed_target_infos,
+        name = label.name,
+        output_group_info = (
+            target[OutputGroupInfo] if OutputGroupInfo in target else None
+        ),
+        product = product,
+        swift_info = swift_info,
+        transitive_infos = transitive_infos,
     )
     target_output_groups = output_groups.collect(
         metadata = target_output_groups_metadata,