Remove deprecated subquestion title formatting code

Should close #4176

Author: elisescu

notifications/services.py

@@ -19,7 +19,6 @@
 from projects.models import Project
 from projects.permissions import ObjectPermission
 from questions.models import Question, UserForecastNotification
-from questions.utils import get_question_group_title
 from users.models import User
 from utils.dtypes import dataclass_from_dict
 from utils.email import send_email_with_template
@@ -202,10 +201,6 @@ def format_cp_change_value(self):
     def format_cp_median(self):
         return self.format_value(self.cp_median)
 
-    def format_question_title(self):
-        # TODO: deprecate get_question_group_title after the first release of this change
-        return self.question.label or get_question_group_title(self.question.title)
-
 
 class NotificationTypeBase:
     type: str

notifications/templates/emails/post_cp_change.html

@@ -242,7 +242,7 @@
                                   </tr>
                                 </thead>
                                 <tbody> {% for item in notification.question_data %} <tr style="{% if not forloop.last %}border-bottom: 1px solid #E5E7EB;{% endif %}">
-                                    <td style="padding: 8px; text-align: left; font-size: 13px; color: #161C22;"> {% if item.question.type == "multiple_choice" %} {{ item.label }} {% else %} {{ item.format_question_title }} {% endif %} </td>
+                                    <td style="padding: 8px; text-align: left; font-size: 13px; color: #161C22;"> {% if item.question.type == "multiple_choice" %} {{ item.label }} {% else %} {{ item.question.label }} {% endif %} </td>
                                     <td style="padding: 8px 4px; text-align: center; font-size: 13px; font-weight: 600; color: #161C22;">
                                       {{ item.get_cp_change_symbol }}{{item.format_cp_change_value }}
                                     </td>

notifications/templates/emails/post_cp_change.mjml

@@ -107,7 +107,7 @@
                                             {% if item.question.type == "multiple_choice" %}
                                                 {{ item.label }}
                                             {% else %}
-                                                {{ item.format_question_title }}
+                                                {{ item.question.label }}
                                             {% endif %}
                                         </td>
                                         <td style="padding: 8px 4px; text-align: center; font-size: 13px; font-weight: 600; color: #161C22;">

questions/utils.py

@@ -1,23 +1,11 @@
 import datetime
-import re
 from datetime import timedelta
 
 from django.utils import timezone
 
 from questions.models import Question, AggregateForecast, Forecast
 
 
-def get_question_group_title(title: str) -> str:
-    """
-    Extracts name from question of group.
-
-    E.g. Long Question Title? (Option A) -> Option A
-    """
-
-    matches = re.findall(r"\((?:[^()]*|\([^()]*\))*\)", title)
-    return matches[-1][1:-1] if matches else title
-
-
 def calculate_question_lifespan_from_date(
     question: Question, from_date: datetime.datetime
 ) -> float | None: