fix Perl warning

Author: yaswant

.github/linters/.ruff.toml

@@ -0,0 +1,21 @@
+cache-dir = "/tmp/.ruff_cache"
+line-length = 120
+
+[lint]
+# C0114: Missing module docstring (missing-module-docstring)
+# C0116: Missing function or method docstring (missing-function-docstring)
+# C0103: Constant name doesn't conform to UPPER_CASE naming style (invalid-name)
+# C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
+# W0622: Redefining built-in 'copyright' (redefined-builtin)
+# R0801: Similar lines in 2 files
+ignore = ["C0114","C0116","C0103","C0209","W0622","R0801",]
+
+# Allow unused variables when underscore-prefixed.
+dummy-variable-rgx = "^(_+|(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?))$"
+
+[format]
+# Like Black, indent with spaces, rather than tabs.
+indent-style = "space"
+
+# Like Black, respect magic trailing commas.
+skip-magic-trailing-comma = false

.gitignore

@@ -1,2 +1,6 @@
+*.sublime-workspace
+*.code-workspace
+.vscode
 __pycache__/
-
+*.pyc
+*~

README.md

@@ -1,3 +1,5 @@
+[![Checks](https://github.com/MetOffice/SimSys_Scripts/actions/workflows/lint.yml/badge.svg)](https://github.com/MetOffice/SimSys_Scripts/actions/workflows/lint.yml)
+
 # SimSys Scripts
 
 This repository contains support scripts that are common across the many

script_umdp3_checker/bin/umdp3_check.pl

@@ -1133,12 +1133,12 @@ sub run_checks {
                     $filename .= ".";
                 }
                 $filename = $log_cylc . "." . $filename . "report";
-                my $fileres = open( FH, '>', $filename );
+                my $fileres = open( my $fh, '>', $filename );
                 if ( !defined $fileres ) {
                     die "ERR: $filename\n";
                 }
-                print FH $failure_text;
-                close(FH);
+                print $fh $failure_text;
+                close($fh);
             }
         }
         $message = '';