Skip to content

Commit 5d11169

Browse files
committed
fix: Custom JAVA_HOME on Windows not finding javac
1 parent fa581bb commit 5d11169

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/main/java/org/mcphackers/mcp/tasks/TaskRecompile.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import org.mcphackers.mcp.MCPPaths;
55
import org.mcphackers.mcp.tasks.mode.TaskParameter;
66
import org.mcphackers.mcp.tools.FileUtil;
7+
import org.mcphackers.mcp.tools.OS;
78
import org.mcphackers.mcp.tools.Util;
89

910
import javax.tools.*;
@@ -201,7 +202,8 @@ public void recompile(MCP mcp, Side side, String javaHome, Iterable<File> src, I
201202
e.printStackTrace();
202203
}
203204

204-
Path javac = Paths.get(javaHome).resolve("bin").resolve("javac");
205+
boolean isWindows = OS.getOs().equals(OS.windows);
206+
Path javac = Paths.get(javaHome).resolve("bin").resolve(isWindows ? "javac.exe" : "javac");
205207
if (!Files.exists(javac)) {
206208
throw new RuntimeException("Failed to find javac in " + javaHome);
207209
}

0 commit comments

Comments
 (0)