Merge pull request #3846 from BsAtHome/fix_hal-private

hal: don't unnecessary include hal_priv.h header

Author: andypugh

src/hal/hal.hh

@@ -5,13 +5,19 @@
 #include <string>
 #include <variant>
 #include "hal.h"
-#include "hal_priv.h"
 
 enum class hal_dir{
     IN = HAL_IN,
     OUT = HAL_OUT,
 };
 
+#if 0
+// If this class is ever necessary, then it needs to be moved into a new
+// header 'hal_priv.hh' because it uses internal access methods from
+// 'hal_priv.h' that should not be available to the casual source file.
+
+#include "hal_priv.h"
+
 class hal{
     public:
     static bool component_exists(const std::string& name){
@@ -34,6 +40,7 @@ class hal{
         return thecomp && (thecomp->ready != 0);
     }
 };
+#endif
 
 template<typename T>
 class hal_pin{

src/hal/utils/halcmd.c

@@ -66,7 +66,6 @@ FILE *halcmd_inifile = NULL;
 
 #include <rtapi.h>		/* RTAPI realtime OS API */
 #include <hal.h>		/* HAL public API decls */
-#include "../hal_priv.h"	/* private HAL decls */
 #include "halcmd_commands.h"
 
 /***********************************************************************