"B" as suffix, or prefix, for Boxed types

[dejlek]

While working on libsecret I had to do the same thing we did in many other def files:

//!subdtype Value ValueSecret

We had similar in Atk - ValueAtk, etc. These names are confusing. How about we rename them to SecretValueB or BSecretValue, so we know immediately those are Boxed subclasses? Or even more verbose BoxedSecretValue ?

Thoughts?

[elementgreen]

I agree, it is confusing. However, I don't like the idea of adding a type identifier to the name, since this would be inconsistent with the rest of the API and most GIR bindings I've seen.

I'm pretty much done with the changes to gidgen to use fully qualified types. So this might resolve this issue and we could just make them Value again?

I'm working through some other issues with the Gtk3 binding and will hopefully have something working shortly.

[dejlek]

That is good news! Let's hope that fixes this annoying issue. :)

[elementgreen]

Commit 2a92470 removed several of the renames, since they now work with the fully qualified symbols. I left the following ones still renamed, since they conflict with some fundamental phobos symbols: ObjectAtk, MonitorG, VariantG, ErrorG, ObjectG. I think it makes sense to leave those as is.

[dejlek]

I just pulled all and I like it! It is more verbose, but it is obvious what is going on at least. We can also improve generator later to provide more structured method/function signatures.

For an example

gio.file_output_stream.FileOutputStream replace(string etag, bool makeBackup, gio.types.FileCreateFlags flags, gio.cancellable.Cancellable cancellable);

becomes something like:

gio.file_output_stream.FileOutputStream 
replace(string                      etag, 
        bool                        makeBackup, 
        gio.types.FileCreateFlags   flags, 
        gio.cancellable.Cancellable cancellable);

This is not urgent ofc, lets first test everything before we move further... I am going to port migrate DIDE to giddy now as it depends on Gtk3, Vte2 and GtkSource4 (PR for that will come in few minutes).

[elementgreen]

Or just rely on the generated documentation do do the formatting.

[dejlek]

My personal way of reading the "documentation" is CTRL-click (on method/function/symbol) to go to the source. :)

[elementgreen]

Ohh! Did not realize it was directly linked like that. Cool! How do you regenerate the docs? They seem to be outdated with the updated package names and additional packages.