Skip to content

Commit 2fe1379

Browse files
Restructure legacy CSS files (#3314)
More incremental progress towards an eventual switch from Laravel Mix to Vite, by reducing the number of CSS targets to be built.
1 parent 335615e commit 2fe1379

File tree

4 files changed

+11
-15
lines changed

4 files changed

+11
-15
lines changed

resources/css/legacy.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
@import 'bootstrap/dist/css/bootstrap.css';
2+
@import 'jquery-ui-dist/jquery-ui.css';
3+
@import 'nvd3/build/nv.d3.min.css';
4+
@import 'bootstrap.min.css';
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@import 'legacy.css';
2+
13
.tooltip {
24
display: block !important;
35
z-index: 10000;

resources/views/cdash.blade.php

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,24 +30,20 @@
3030

3131
{{-- Framework-specific details --}}
3232
@if(isset($angular) && $angular === true)
33-
<link rel="stylesheet" type="text/css" href="{{ asset(mix('assets/css/legacy_3rdparty.css')) }}"/>
33+
<link rel="stylesheet" type="text/css" href="{{ asset(mix('assets/css/legacy.css')) }}"/>
3434
<link rel="stylesheet" type="text/css" href="{{ asset(mix(get_css_file())) }} }}"/>
35-
<link rel="stylesheet" href="{{ asset(mix('assets/css/bootstrap.min.css')) }}"/>
3635
<script src="{{ asset(mix('assets/js/legacy.js')) }}"></script>
3736
@elseif(isset($vue) && $vue === true)
3837
<link rel="stylesheet" type="text/css" href="{{ asset(mix(get_css_file())) }}"/>
3938
@if(isset($daisyui) && $daisyui === true)
4039
<link rel="stylesheet" type="text/css" href="{{ asset(mix('assets/css/app.css')) }}"/>
4140
@else
42-
<link rel="stylesheet" type="text/css" href="{{ asset(mix('assets/css/legacy_3rdparty.css')) }}"/>
43-
<link rel="stylesheet" type="text/css" href="{{ asset(mix('assets/css/vue_common.css')) }}"/>
44-
<link rel="stylesheet" type="text/css" href="{{ asset(mix('assets/css/bootstrap.min.css')) }}"/>
41+
<link rel="stylesheet" type="text/css" href="{{ asset(mix('assets/css/legacy_vue.css')) }}"/>
4542
@endif
4643
<script src="{{ asset(mix('assets/js/app.js')) }}" type="text/javascript" defer></script>
4744
@else
48-
<link rel="stylesheet" type="text/css" href="{{ asset(mix('assets/css/legacy_3rdparty.css')) }}"/>
45+
<link rel="stylesheet" type="text/css" href="{{ asset(mix('assets/css/legacy.css')) }}"/>
4946
<link rel="stylesheet" type="text/css" href="{{ asset(mix(get_css_file())) }}"/>
50-
<link rel="stylesheet" href="{{ asset(mix('assets/css/bootstrap.min.css')) }}"/>
5147
<script src="{{ asset(mix('assets/js/legacy.js')) }}"></script>
5248
@if(str_contains(request()->url(), 'viewCoverage.php')) {{-- This last XSL page needs special treatment... --}}
5349
<link rel="stylesheet" type="text/css" href="{{ asset(mix('assets/css/jquery.dataTables.css')) }}"/>

webpack.mix.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,9 @@ mix.copy('resources/js/angular/views/partials/*.html', 'public/assets/js/angular
2626
mix.css('resources/css/cdash.css', 'public/assets/css/cdash.css');
2727
mix.css('resources/css/colorblind.css', 'public/assets/css/colorblind.css');
2828
mix.css('resources/css/jquery.dataTables.css', 'public/assets/css/jquery.dataTables.css');
29-
mix.css('resources/css/bootstrap.min.css', 'public/assets/css/bootstrap.min.css');
30-
mix.css('resources/css/vue_common.css', 'public/assets/css/vue_common.css');
31-
32-
mix.styles([
33-
'node_modules/bootstrap/dist/css/bootstrap.css',
34-
'node_modules/jquery-ui-dist/jquery-ui.css',
35-
'node_modules/nvd3/build/nv.d3.min.css',
36-
], 'public/assets/css/legacy_3rdparty.css');
3729

30+
mix.css('resources/css/legacy.css', 'public/assets/css/legacy.css');
31+
mix.css('resources/css/legacy_vue.css', 'public/assets/css/legacy_vue.css');
3832
mix.sass('resources/sass/app.scss', 'public/assets/css/app.css');
3933

4034
mix.copy('resources/js/angular/jquery.dataTables.min.js', 'public/assets/js/jquery.dataTables.min.js');

0 commit comments

Comments
 (0)