Skip to content

Commit 9c5e0d6

Browse files
authored
Changing the masking-shadowing function referenced in the 2.0 specifications (#2541)
* Changing the masking-shadowing function referenced in the spec to match the implementation used in the glTF-Sample-Viewer. * Correcting typo
1 parent 3e9dfff commit 9c5e0d6

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

specification/2.0/Specification.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3049,11 +3049,11 @@ with the Trowbridge-Reitz/GGX microfacet distribution
30493049
D = \frac{\alpha^2 \, \chi^{+}(N \cdot H)}{\pi ((N \cdot H)^2 (\alpha^2 - 1) + 1)^2}
30503050
++++
30513051

3052-
and the separable form of the Smith joint masking-shadowing function
3052+
and the height-correlated form of the Smith joint masking-shadowing function
30533053

30543054
[latexmath]
30553055
++++
3056-
G = \frac{2 \, \left| N \cdot L \right| \, \chi^{+}(H \cdot L)}{\left| N \cdot L \right| + \sqrt{\alpha^2 + (1 - \alpha^2) (N \cdot L)^2}} \frac{2 \, \left| N \cdot V \right| \, \chi^{+}(H \cdot V)}{\left| N \cdot V \right| + \sqrt{\alpha^2 + (1 - \alpha^2) (N \cdot V)^2}}
3056+
G = \frac{2 \, \left| N \cdot L \right| \, \left| N \cdot V \right| \, \chi^{+}(H \cdot L) \, \chi^{+}(H \cdot V)}{\left| N \cdot V \right| \, \sqrt{\alpha^2 + (1 - \alpha^2) (N \cdot L)^2} + \left| N \cdot L \right| \, \sqrt{\alpha^2 + (1 - \alpha^2) (N \cdot V)^2}}
30573057
++++
30583058

30593059
where χ^+^(*x*) denotes the Heaviside function: 1 if *x* > 0 and 0 if *x* <= 0. See <<Heitz2014,Heitz (2014)>> for a derivation of the formulas.
@@ -3076,7 +3076,7 @@ with
30763076

30773077
[latexmath]
30783078
++++
3079-
\nu = \frac{\, \chi^{+}(H \cdot L)}{\left| N \cdot L\right| + \sqrt{\alpha^2 + (1 - \alpha^2) (N \cdot L)^2}} \frac{\, \chi^{+}(H \cdot V)}{\left| N \cdot V \right| + \sqrt{\alpha^2 + (1 - \alpha^2) (N \cdot V)^2}}
3079+
\nu = \frac{\chi^{+}(H \cdot L) \, \chi^{+}(H \cdot V)}{2 \, (\left| N \cdot V \right| \, \sqrt{\alpha^2 + (1 - \alpha^2) (N \cdot L)^2} + \left| N \cdot L \right| \, \sqrt{\alpha^2 + (1 - \alpha^2) (N \cdot V)^2})}
30803080
++++
30813081

30823082
Thus, we have the function

0 commit comments

Comments
 (0)