Fix WCSExt to properly parse FITS keyword types using parse_header_val#240
Open
cgarling wants to merge 2 commits intoJuliaAstro:mainfrom
Open
Fix WCSExt to properly parse FITS keyword types using parse_header_val#240cgarling wants to merge 2 commits intoJuliaAstro:mainfrom
parse_header_val#240cgarling wants to merge 2 commits intoJuliaAstro:mainfrom
Conversation
Co-authored-by: cgarling <20730107+cgarling@users.noreply.github.com> Agent-Logs-Url: https://github.com/cgarling/FITSIO.jl/sessions/db2f8d3d-a1ee-4ebb-b358-c1f2c4e6ac9e
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
- Coverage 92.10% 92.09% -0.02%
==========================================
Files 7 7
Lines 722 721 -1
==========================================
- Hits 665 664 -1
Misses 57 57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #239. @andrew-saydjari could you demo this with your workflow to verify it fixes the problem you noticed?