Project fixup Part 2

[icweaver]

Follow-up from #72

What's changed

• Moved ccd2rgb tests into imview tests. ccd2rgb seemed to use the old pre-v0.3 api for AstroImages.jl, so a lot of the tests did not seem applicable anymore. I moved the remaining bits over to the imview test file and commented it out for now. 4bdf552
• Static test data. Used to be downloaded each time, but the datasets are small enough to avoid that additional machinery. One of the online sources that was used is also no longer active, so this avoids that issue too.
• Updated AstroImage constructor so that AstroImage(data, [wcs]) will work
  417fd54. Needed for plots tests.

To-do

• Explicit imports
• Get commented out tests from upstream working
  • ccd2rgb
  • plots

[codecov]

Codecov Report

❌ Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.33%. Comparing base (2fe0847) to head (4d31722).
⚠️ Report is 15 commits behind head on master.

Files with missing lines	Patch %	Lines
src/imview.jl	73.33%	4 Missing ⚠️
src/AstroImages.jl	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master      #75       +/-   ##
===========================================
+ Coverage   21.73%   54.33%   +32.59%     
===========================================
  Files          11       10        -1     
  Lines        1127     1119        -8     
===========================================
+ Hits          245      608      +363     
+ Misses        882      511      -371     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[icweaver]

Ok, I think this is in a pretty ok place now for a review. I've updated the parent comment with a brief summary. Happy to make any changes!

[cgarling]

Looks good! Just one comment about the AstroImage function.

Edit: The documentation action failure seems to be related to a failure downloading a file. Was this just a random error / does the documentation build locally?

[cgarling]

What's the significance of this change? Also the docstring says it takes a WCSTransform but I only see methods for Vector{WCSTransform}, am I missing something?

[icweaver]

That was a little weird to me too. When I got to updating the plots tests, I needed a way to build an AstroImage(data, [wcs]) object, and updating the signature to Vector{WCSTransform} looked to have the desired effect for this while touching the least amount of pre-existing machinery.

I don't do a lot of work with WCS, but I guess that folks want to have the option of passing multiple WCSTransform objects, so this is what I went with. I updated the docstrings to make this more consistent, and added a convenience constructor so AstroImage(data, wcs) will work too. Does this seem alright to you? 442b68b

[cgarling]

Yeah, AstroImage(data::AbstractArray, wcs::WCSTransform) = AstroImage(data, [wcs]) was pretty much what I was thinking might be needed, thanks

[icweaver]

Thanks! I think it was just a random data download timeout. Docs are building locally now, will work on getting CI builds working next.

I added a couple things that I missed earlier:

1. Re-export (..) from DimensionalData/IntervalSets now that we are doing explicit imports in this PR
2. Put [sources] back in the docs Project.toml until docs: Use latest stable version of julia #73 is resolved

[icweaver]

Ok, am hitting using DimensionalData: :.. vs. using DimensionalData: .. based on what version of Julia we use. Have you seen this before? Currently looking for a workaround that works across versions

Update: Parentheses!