Conversation
Member
|
Thanks so much for looking into this @icweaver ! I won’t be able to review until next week, but please go ahead and merge whatever changes to the docs you think are best. yeah, the colour channels were different sizes so I had originally cropped them to match, hence why I was rehosting them. |
Member
Author
|
For sure, I'll go ahead and merge this then just to get the doc builds passing again. By eye, the rough cropping I did seems to get us close enough until a nicer solution is added. Thanks William! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc preview: https://juliaastro.org/AstroImages.jl/previews/PR62/
Switched stale urls to some other hosted alternatives. I think I was able to find exact replacements for all of them except the following, which could use some review:
http://www.astro.uvic.ca/~wthompson/astroimages/fits/mw-crop2-small.png(replaced with https://upload.wikimedia.org/wikipedia/commons/1/15/154-panel_Widefield_Milky_Way_Panorama.jpg)http://www.astro.uvic.ca/~wthompson/astroimages/fits/antenae/green.fits(replaced with https://esahubble.org/static/projects/fits_liberator/datasets/antennae/green.fits)http://www.astro.uvic.ca/~wthompson/astroimages/fits/antenae/hydrogen.fitsreplaced with https://esahubble.org/static/projects/fits_liberator/datasets/antennae/hydrogen.fitsThese last two looked to be a bit smaller than their other color channels, so I just trimmed them to match, e.g.,
so that the color stacking bit of the docs would run